Merged
Conversation
"default_310" is no longer an appropriate name since we have set python = "3.12".
Test for only one Python version locally, or it will be too time consuming. (Build tests for four Python versions will be added to CI).
'requires-python = ">=3.10, <=3.13"' does NOT include e.g. Python 3.13.1
Contributor
|
I took a look at the coverage warnings as well as the multiprocessing warnings, but 3.13 still has a linting issue. I can look at that next week. Have a nice weekend :) |
Collaborator
Author
|
Thanks for your commit. I will try to fix the linting issue in the next hour or so. Have a nice weekend. |
Mypy is being overly cautious about dataclass inheritance.
This only occurs for mypy type checking for Python 3.13, i.e. not for earlier Python versions - with their corresponding mypy versions.
One of the two error messages is
'
sourcefinder/accessors/lofarfitsimage.py:5: error: Definition of "__replace__"
Installing missing stub packages:
in base class "DataAccessor" is incompatible with definition in base class
"LofarAccessor" [misc]
class LofarFitsImage(FitsImage, LofarAccessor):
'
and the other one, for "class LofarCasaImage(CasaImage, LofarAccessor)", is similar.
No "__replace__" method has been implemented, so it is unclear where this error message comes from.
We therefore assume that mypy has inferred this incorrectly.
Collaborator
Author
|
The problem with the coverage files seems to persist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138
Also updates
pyproject.tomlto use Python 3.12 as default and for testing.