Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks system so wrapping every device in
Deviceis no longer needed.Deviceis now a type ofRc<RefCell<dyn DynDevice>>whereDynDeviceistrait DynDevice: Any + 'static + Transmutable.That way the Transmutable methods can be called on the new Device type, making it work very similarly to the old one.
It also allows access to any device added to a system by calling
get_deviceorget_device_by_nameon the system, with the type of the device as a generic. The generic is checked against the type id of thedyn DynDeviceand will error out if they don't match, a cast to a different device by accident is not possible. This system is used in the deno projects core for a resource table whic is used extensively.DynDeviceis implemented for every type that implementsTransmutable + 'static, so devices do not have to implement it manually.Adding a new device to the system now returns a
DeviceIdwhich can be used to get access to the device again. If the id is unknown, devices can also be found through their set name (if they have one).The event queue and debuggables list now both hold device ids instead of the device directly.
There is now a
DeviceSettingsstruct which can be used when adding a device to a system. Methods likeadd_addressable_device, add_interruptable_device, add_peripheralstill exists but useDeviceSettingsinternaly