Skip to content

Comments

Update transitionnetwork.org-d6.make#1

Open
sam-transition wants to merge 1 commit intotransitionnetwork:masterfrom
sam-transition:patch-1
Open

Update transitionnetwork.org-d6.make#1
sam-transition wants to merge 1 commit intotransitionnetwork:masterfrom
sam-transition:patch-1

Conversation

@sam-transition
Copy link

@benjarlett
Copy link

You put it in the makefile too? ...Probably... Just saying what I'm
thinking... Probably ignore me...

-----------emailme@benjarlett.co.uk
www.benjarlett.co.uk
07734 970739

On 29 Jan 2014, at 16:57, sam-transition notifications@github.com wrote:

Added patch for location.module

https://drupal.org/files/issues/location.module_34.patch

You can merge this Pull Request by running

git pull https://github.com/sam-transition/transitionnetwork.org-d6.profile
patch-1

Or view, comment on, or merge it at:

#1
Commit Summary

  • Update transitionnetwork.org-d6.make

File Changes

Patch Links:

https://github.com/transitionnetwork/transitionnetwork.org-d6.profile/pull/1.patch

https://github.com/transitionnetwork/transitionnetwork.org-d6.profile/pull/1.diff

Reply to this email directly or view it on
GitHubhttps://github.com//pull/1
.

@i-jk
Copy link

i-jk commented Jan 30, 2014

Thanks, a couple of points:

  1. If the patch is needed for normal operation of the site, then it needs to be in the makefile up to the point the module is fixed and the patch is no longer needed.
  2. The patch you've suggested only has a comment describing it, not the line for Drush Make to include actual patch -- please do another one that includes the required line (see other patch lines in the makefile for examples).

Cheers!

@i-jk i-jk closed this Jan 30, 2014
@i-jk
Copy link

i-jk commented Feb 9, 2014

Didn't mean to close this -- just wanted Sam to do commit something that includes the patch.

Re-opening, sorry for the confusion... Sam, all good? Can you commit a correction to this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants