Skip to content

Conversation

@vickymmcd
Copy link
Contributor

Adds some bus routes to the gtfs schedule generation

@vickymmcd vickymmcd requested a review from idreyn as a code owner August 25, 2025 02:03
Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, with the exception that we probably don't want to include these bus routes in the regional-rail scenario, just the expansion scenario. This seems to add them to both. Can we easily do that? Or is that going to heavily complicate this?

@vickymmcd
Copy link
Contributor Author

@devinmatte I can just revert the changes to the regional rail files if that's what you mean, but the next time someone generates for regional rail, I think they will get the changes. I'm not sure of an easy way to exclude the buses just from regional rail generation, but maybe @idreyn has an idea? We might need to generate generate 2 different relevant_stop_times files if we want that, which would probably be do-able, but a bit more work

@devinmatte
Copy link
Member

Yeah I see the issue. If there's not a simple fix then that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants