Skip to content

Remove unused duplicate code and improve build configuration #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 19, 2025
Merged

Remove unused duplicate code and improve build configuration #79

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d42dd6
Initial plan
Copilot Jul 19, 2025
34abc31
Initial analysis of repository for unused code identification
Copilot Jul 19, 2025
75323b7
Remove duplicate sampling percentage logic from SecondEntryPoint
Copilot Jul 19, 2025
0c7a55b
Add Kotlin build artifacts to .gitignore and remove committed build a…
Copilot Jul 19, 2025
4f5dcf3
Revert .gitignore changes as requested
Copilot Jul 19, 2025
7072c9c
Merge branch 'main' into copilot/fix-78
trask Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Gradle
/.gradle/
/buildSrc/.gradle/
/buildSrc/.kotlin/
build/

# Intellij
Expand Down
7 changes: 0 additions & 7 deletions ...src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,20 +166,13 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {

TelemetryClient.setActive(telemetryClient);

// TODO (heya) remove duplicate code in both RuntimeConfigurator and SecondEntryPoint
RuntimeConfigurator runtimeConfigurator =
new RuntimeConfigurator(
telemetryClient,
() -> logFilteringProcessor,
configuration,
heartbeatTelemetryItemConsumer,
tempDir);

if (configuration.sampling.percentage != null) {
BytecodeUtilImpl.samplingPercentage = configuration.sampling.percentage.floatValue();
} else {
BytecodeUtilImpl.samplingPercentage = 100;
}
BytecodeUtilImpl.featureStatsbeat = statsbeatModule.getFeatureStatsbeat();
BytecodeUtilImpl.runtimeConfigurator = runtimeConfigurator;
BytecodeUtilImpl.connectionStringConfiguredAtRuntime =
Expand Down
Loading