Sync checkstyle configuration with opentelemetry-java-instrumentation #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: trask <[email protected]>
…ntln Co-authored-by: trask <[email protected]>
Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
[WIP] Sync checkstyle configuration with opentelemetry-java-instrumentation
Sync checkstyle configuration with opentelemetry-java-instrumentation
Jul 19, 2025
Copilot finished work on behalf of
trask
July 19, 2025 17:16
trask
reviewed
Jul 19, 2025
…on declarations Co-authored-by: trask <[email protected]>
Copilot finished work on behalf of
trask
July 19, 2025 17:36
trask
reviewed
Jul 19, 2025
...osoft/applicationinsights/agent/internal/classicsdk/TelemetryClientClassFileTransformer.java
Outdated
Show resolved
Hide resolved
…ights/agent/internal/classicsdk/TelemetryClientClassFileTransformer.java
trask
added a commit
that referenced
this pull request
Jul 19, 2025
trask
added a commit
that referenced
this pull request
Jul 21, 2025
…#89) * Initial plan * Sync checkstyle configuration with OpenTelemetry Co-authored-by: trask <[email protected]> * Fix checkstyle violations from sync: logger naming and system.out.println Co-authored-by: trask <[email protected]> * Complete checkstyle sync - fix all remaining logger naming violations Co-authored-by: trask <[email protected]> * Address review comments: remove backup file and relocate plugin version declarations Co-authored-by: trask <[email protected]> * Update agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/TelemetryClientClassFileTransformer.java --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: trask <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
trask
added a commit
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR synchronizes the checkstyle configuration with the one used by the upstream opentelemetry-java-instrumentation project to maintain consistency in code style and quality standards.
Key Changes to checkstyle.xml
Added new rules from OpenTelemetry:
CHECKSTYLE:OFF/CHECKSTYLE:ONcomment-based suppressionsSystem.out.print,System.err.print,printStackTrace(), andThread.dumpStack()loggerinstead ofLOGGER,LOG, orlogRemoved/modified rules:
^[A-Z]+[0-9]?$for consistencyFixed Checkstyle Violations
Fixed 16 files with logger naming violations (renamed
LOGGERtologger):SnippetConfiguration.java,DllFileUtils.java,EtwProvider.javaNotificationObserver.java,GcCollectionSample.javaAlertingSubsystem.java,AlertPipelines.java,SingleAlertPipeline.javaCodeOptimizerDiagnosticEngineJfr.java,CalibratorDefault.javaLinuxProcessCpuStats.java,LinuxProcessIoStats.java,LinuxProcessDumper.javaTwoStepProcReader.java,OperatingSystemDetector.java,SystemStatsProvider.javaCodeOptimizerDiagnosticsJfrInit.java,DiagnosticsLoggerProxy.javaAdditional Changes
com.github.ben-manes.versionsplugin insettings.gradle.ktsTelemetryClientClassFileTransformer.javaVerification
✅ All checkstyle checks now pass across the entire codebase:
./gradlew checkstyleMain --continue # BUILD SUCCESSFUL - 59 actionable tasks: 1 executed, 58 up-to-dateThe configuration maintains compatibility with the existing Checkstyle 8.37 version while adopting the latest standards from the upstream project.
Fixes #88.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.