Skip to content

Fix KafkaTest smoke test by upgrading Spring Kafka version #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix KafkaTest smoke test by upgrading Spring Kafka version #91

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99a5920
Initial plan
Copilot Jul 19, 2025
6985942
Fix KafkaTest smoke test by upgrading Spring Kafka version
Copilot Jul 19, 2025
c4ae83f
Revert settings.gradle.kts plugin version, add versions to plugin blo…
Copilot Jul 19, 2025
085c328
Merge branch 'main' into copilot/fix-90
trask Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions settings.gradle.kts
View file
Open in desktop
Copy link
Owner

@trask trask Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Copy link
Author

Copilot AI Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the settings.gradle.kts changes and moved the plugin version declarations inline to the plugin blocks where they're used. Build and Kafka smoke test verified to work correctly. c4ae83f

Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import org.apache.tools.ant.taskdefs.condition.Os

pluginManagement {
plugins {
id("com.github.ben-manes.versions") version "0.51.0"
id("com.github.jk1.dependency-license-report") version "2.9"
id("me.champeau.jmh") version "0.7.3"
id("com.gradle.plugin-publish") version "1.3.1"
Expand Down
2 changes: 1 addition & 1 deletion smoke-tests/apps/Kafka/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ plugins {

dependencies {
implementation("org.springframework.boot:spring-boot-starter-web:2.7.18")
implementation("org.springframework.kafka:spring-kafka:2.3.1.RELEASE")
implementation("org.springframework.kafka:spring-kafka:2.8.11")
implementation("com.fasterxml.jackson.core:jackson-databind:2.10.0")
implementation("org.apache.httpcomponents:httpclient:4.5.13")
implementation("org.testcontainers:kafka:1.17.3")
Expand Down
Loading