Skip to content

Commit da71bc1

Browse files
committed
Merge PR #382: Update gcp-resources module to follow style guide
2 parents 5d4eaf5 + 7189107 commit da71bc1

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

gcp-resources/src/main/java/io/opentelemetry/contrib/gcp/resource/GCPResourceProvider.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,10 @@
6262
import java.util.logging.Logger;
6363

6464
@SuppressWarnings("MemberName")
65-
public class GCPResourceProvider implements ConditionalResourceProvider {
65+
public final class GCPResourceProvider implements ConditionalResourceProvider {
6666

6767
private static final Logger LOGGER = Logger.getLogger(GCPResourceProvider.class.getSimpleName());
68+
6869
private final GCPPlatformDetector detector;
6970

7071
// for testing only

gcp-resources/src/main/java/io/opentelemetry/contrib/gcp/resource/IncubatingAttributes.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
*/
1414
class IncubatingAttributes {
1515

16-
private IncubatingAttributes() {}
17-
1816
public static final AttributeKey<String> CLOUD_ACCOUNT_ID =
1917
AttributeKey.stringKey("cloud.account.id");
2018
public static final AttributeKey<String> CLOUD_AVAILABILITY_ZONE =
@@ -26,14 +24,15 @@ private IncubatingAttributes() {}
2624
public static final AttributeKey<String> CLOUD_REGION = AttributeKey.stringKey("cloud.region");
2725

2826
public static final class CloudPlatformIncubatingValues {
29-
private CloudPlatformIncubatingValues() {}
3027

3128
public static final String GCP_COMPUTE_ENGINE = "gcp_compute_engine";
3229
public static final String GCP_CLOUD_RUN = "gcp_cloud_run";
3330
public static final String GCP_KUBERNETES_ENGINE = "gcp_kubernetes_engine";
3431
public static final String GCP_CLOUD_FUNCTIONS = "gcp_cloud_functions";
3532
public static final String GCP_APP_ENGINE = "gcp_app_engine";
3633
public static final String GCP = "gcp";
34+
35+
private CloudPlatformIncubatingValues() {}
3736
}
3837

3938
public static final AttributeKey<String> FAAS_INSTANCE = AttributeKey.stringKey("faas.instance");
@@ -56,4 +55,6 @@ private CloudPlatformIncubatingValues() {}
5655

5756
public static final AttributeKey<String> K8S_CLUSTER_NAME =
5857
AttributeKey.stringKey("k8s.cluster.name");
58+
59+
private IncubatingAttributes() {}
5960
}

0 commit comments

Comments
 (0)