Update jfr-connection module to follow style guide #362
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR updates the jfr-connection module to comply with the OpenTelemetry Java Contrib style guide (docs/style-guide.md), excluding the
@Nullableannotation usage section as requested.Changes Made
Static Imports
Added static imports for commonly used methods and constants according to the style guide:
Objects.requireNonNullin FlightRecorderMXBeanConnection and FlightRecorderDiagnosticCommandConnectionCollections.unmodifiableMapin RecordingOptionsArrays.streamin FlightRecorderDiagnosticCommandConnectionjava.util.stream.Collectors.*(toList, toMap, joining) across multiple filesStandardCharsets.UTF_8in JfcFileConfigurationClass Organization
Fixed class organization to follow the preferred order:
Final Keyword Usage
Added
finalmodifiers to public non-internal classes where appropriate:Note: The Recording class was left non-final due to ErrorProne constraints that prevent compilation when the class is marked final.
Verification
All changes are minimal and focused solely on style guide compliance. The module builds successfully, passes all existing tests, and maintains full backward compatibility.
Fixes #361.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.