Skip to content

Conversation

Copy link

Copilot AI commented Aug 25, 2025

Updated the jfr-events module to comply with the OpenTelemetry Java Contrib style guide requirements with minimal changes:

Changes Made

  1. Test method visibility: Removed public modifiers from test methods in JfrSpanProcessorTest to follow the style guide requirement that test methods should be package-protected rather than public.

  2. Static import alignment: Updated the static import in the test class to use the recommended org.assertj.core.api.Assertions.assertThat instead of org.assertj.core.api.AssertionsForInterfaceTypes.assertThat as specified in the style guide.

Validation

  • All existing tests continue to pass
  • Code formatting verified with ./gradlew spotlessCheck
  • Build verification completed successfully

The changes are minimal and surgical, addressing only the specific style guide compliance issues while preserving all existing functionality. The module's public classes were already properly declared as final and other style guide requirements were already met.

Fixes #363.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@trask trask closed this Aug 25, 2025
Copilot AI changed the title [WIP] Update jfr-events module to follow style guide Update jfr-events module to follow style guide Aug 25, 2025
Copilot AI requested a review from trask August 25, 2025 00:33
Copilot finished work on behalf of trask August 25, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update jfr-events module to follow style guide

2 participants