Update cloudfoundry-resources module to follow style guide #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add static imports for AttributeKey.stringKey, Assertions.*, and Collectors.joining - Make public classes CloudFoundryResourceProvider and CloudFoundryResourceDetector final - Add @autoservice annotations to SPI implementations - Add AutoService dependencies to build.gradle.kts - Remove manual META-INF/services files (replaced by AutoService) - All tests pass and code formatting is compliant Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
trask
August 25, 2025 01:07
trask
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the cloudfoundry-resources module to comply with all recommendations in
docs/style-guide.md. Made minimal, targeted changes to ensure style guide compliance while maintaining existing functionality.Changes Made
Static Imports: Added static imports for commonly used methods and constants as recommended by the style guide:
AttributeKey.stringKeyfor cleaner attribute key creationAssertions.*andCollectors.joiningin test files for better readabilityClass Declarations: Made public non-internal classes
finalas required:CloudFoundryResourceProvideris nowfinalCloudFoundryResourceDetectoris nowfinalAutoService Integration: Replaced manual service registration with
@AutoServiceannotations:@AutoService(ResourceProvider.class)toCloudFoundryResourceProvider@AutoService(ComponentProvider.class)toCloudFoundryResourceDetectorbuild.gradle.ktsMETA-INF/services/files (now auto-generated)All tests pass and the module builds successfully. The AutoService annotations automatically generate the correct service registration files at compile time, eliminating the need for manual maintenance of these files.
Fixes #375.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.