forked from open-telemetry/opentelemetry-java-contrib
-
Notifications
You must be signed in to change notification settings - Fork 1
Update disk-buffering module to follow style guide recommendations #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
21
commits into
main
Choose a base branch
from
copilot/fix-377
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: trask <[email protected]>
Copilot finished work on behalf of
trask
August 25, 2025 01:15
trask
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the disk-buffering module to fully comply with the project's style guide recommendations, making minimal but focused changes across 61 Java files.
Key Changes Made
Final Keyword Usage
Added
final
to 6 public API classes that should be final per style guide:SpanToDiskExporter
,SpanFromDiskExporter
LogRecordToDiskExporter
,LogRecordFromDiskExporter
MetricToDiskExporter
,MetricFromDiskExporter
Removed
final
from 23+ internal and package-private classes that should not be final according to style guide requirementsStatic Imports
Added static imports for commonly used constants as recommended:
TimeUnit.SECONDS
,TimeUnit.HOURS
,TimeUnit.MILLISECONDS
Level.INFO
,Level.WARNING
,Level.FINER
This improves code readability by eliminating repetitive qualified references like
TimeUnit.SECONDS.toMillis(30)
in favor ofSECONDS.toMillis(30)
.Class Organization
Fixed class organization issues to follow the recommended order:
Specifically corrected field ordering in
SpanToDiskExporter
and constructor placement in nested Builder classes.Testing
All existing tests (118 total) continue to pass, ensuring no behavioral regressions from these style improvements.
The changes follow the principle of minimal modification while ensuring full compliance with the style guide for better code consistency and maintainability.
Fixes #377.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.