Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Aug 25, 2025

Plan to update maven-extension module to follow style guide

Based on analysis of the style guide and current code, here are the minimal changes needed:

Public Classes That Need final Keyword

  • MavenOtelSemanticAttributes - utility class should be final
  • AutoConfigureUtil2 - utility class should be final
  • MojoGoalExecutionHandlerConfiguration - public class should be final
  • MavenResourceProvider - public class should be final
  • MavenResourceDetector - public class should be final

Test Classes Visibility

  • Remove public from 5 test classes to make them package-protected:
    • OpenTelemetrySdkServiceTest
    • SpanRegistryTest
    • MojoGoalExecutionHandlerTest
    • MojoGoalExecutionHandlerConfigurationTest
    • MavenUtilsTests

Static Imports to Add

  • Review files for opportunities to add static imports for commonly used methods (AttributeKey., Assertions., Collections.*, etc.)

Field Finalization

  • Review fields that could be declared final

Class Organization

  • Verify proper ordering of members (static fields, instance fields, constructors, methods, nested classes)

The plan focuses on minimal changes and follows the principle of making the least invasive modifications possible.

Fixes #397.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update maven-extension module to follow style guide
2 participants