forked from open-telemetry/opentelemetry-java-contrib
-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Update maven-extension module to follow style guide #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
20
commits into
main
Choose a base branch
from
copilot/fix-397
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot stopped work on behalf of
trask due to an error
August 25, 2025 01:36
trask
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan to update maven-extension module to follow style guide
Based on analysis of the style guide and current code, here are the minimal changes needed:
Public Classes That Need
final
KeywordMavenOtelSemanticAttributes
- utility class should be finalAutoConfigureUtil2
- utility class should be finalMojoGoalExecutionHandlerConfiguration
- public class should be finalMavenResourceProvider
- public class should be finalMavenResourceDetector
- public class should be finalTest Classes Visibility
public
from 5 test classes to make them package-protected:OpenTelemetrySdkServiceTest
SpanRegistryTest
MojoGoalExecutionHandlerTest
MojoGoalExecutionHandlerConfigurationTest
MavenUtilsTests
Static Imports to Add
Field Finalization
final
Class Organization
The plan focuses on minimal changes and follows the principle of making the least invasive modifications possible.
Fixes #397.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.