Update noop-api module to follow style guide #402
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
trask
August 25, 2025 01:42
trask
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made minimal changes to ensure the noop-api module follows the OpenTelemetry Java style guide. According to the style guide, "Public non-internal classes should be declared
finalwhere possible."Changes:
finalkeyword toNoopOpenTelemetryclassfinalkeyword toNoopContextStorageProviderclassBoth classes are public, non-internal classes that implement interfaces and don't need to be subclassed, making them ideal candidates for the
finalmodifier. This change improves code clarity by explicitly indicating these classes are not intended for inheritance.All existing tests continue to pass and code formatting remains compliant.
Fixes #401.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.