forked from open-telemetry/opentelemetry-java-contrib
-
Notifications
You must be signed in to change notification settings - Fork 1
Update processors module to follow style guide #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
21
commits into
main
Choose a base branch
from
copilot/fix-405
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: trask <[email protected]>
Copilot finished work on behalf of
trask
August 25, 2025 01:51
trask
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the processors module to follow all recommendations in the style guide, making minimal changes as requested.
Changes Made
The main issue was with
FilteringLogRecordProcessor
which was not following the style guide conventions:FilteringLogRecordProcessor.java
final
to class declaration (style guide requires public non-internal classes to be final where possible)public
toprivate
(following principle of minimal necessary visibility)final
FilteringLogRecordProcessorTest.java
{}
that was preventing the main class from being made finalVerification
All other classes in the processors module were already correctly following the style guide:
EventToSpanEventBridge
- properly final with private final fieldsInterceptableSpanExporter
- properly final with private final fieldsInterceptableLogRecordExporter
- properly final with private final fieldsInterceptableMetricExporter
- properly final with private final fieldsComposableInterceptor
- properly final with private final fieldsEventToSpanEventBridgeComponentProvider
- correctly NOT final (internal package per style guide)Static imports and code formatting were already compliant. All tests pass and
./gradlew spotlessApply
was run to ensure proper formatting.Fixes #405.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.