Update prometheus-client-bridge module to follow style guide #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and class organization Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
trask
August 25, 2025 01:57
trask
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the prometheus-client-bridge module to follow the recommendations in the style guide while making minimal changes to the codebase.
Changes Made
Static Imports
Added static imports for commonly used utility methods as recommended by the style guide:
Collections.unmodifiableListTimeUnit.MILLISECONDSandTimeUnit.NANOSECONDSCollections.emptyListClass Organization
sanitizerstatic field to be grouped with other static fields at the top of the class, following the preferred order: static fields, instance fields, constructors, methods, nested classes.Style Guide Compliance Verified
✅ Code Formatting: All files pass Spotless formatting checks
✅ Final Keyword Usage: Public non-internal classes are correctly declared
final, package-private classes are not✅ Test Class Visibility: Test classes are package-protected (no explicit visibility modifier)
✅ Static Imports: Added for commonly used utilities per style guide recommendations
✅ Class Organization: Follows the preferred field/method ordering
All changes maintain backward compatibility and existing functionality. Tests continue to pass without modification.
Fixes #407.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.