Skip to content

ALL #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

ALL #416

wants to merge 5 commits into from

Conversation

trask
Copy link
Owner

@trask trask commented Aug 25, 2025

No description provided.

trask
trask commented Aug 25, 2025
View reviewed changes
...ring/src/main/java/io/opentelemetry/contrib/disk/buffering/exporters/SpanToDiskExporter.java

private SpanToDiskExporter(
SignalStorageExporter<SpanData> storageExporter, ExporterCallback callback) {
this.storageExporter = storageExporter;
this.callback = callback;
}

public Builder builder(SignalStorage.Span storage) {
public static Builder builder(SignalStorage.Span storage) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trask