Add lychee workarounds and update to v0.20.1 #12
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,23 @@ max_concurrency = 4 | |
| # Check link anchors | ||
| include_fragments = true | ||
|
|
||
| # Include additional file types beyond the default markdown/HTML | ||
| include = [ | ||
| "**/*.md", | ||
| "**/*.java", | ||
| "**/*.yml", | ||
| "**/*.yaml" | ||
trask marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ] | ||
|
|
||
| remap = [ | ||
| # workaround for https://github.com/lycheeverse/lychee/issues/1729 | ||
| "https://github.com/(.*?)/(.*?)/blob/(.*?)/(.*#.*)$ https://raw.githubusercontent.com/$1/$2/$3/$4", | ||
trask marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "https://docs.oracle.com/(.*)#.*$ https://docs.oracle.com/$1" | ||
|
There was a problem hiding this comment. @copilot check if any links in this repo need this There was a problem hiding this comment. Yes, this remap is needed. Found 8 Oracle docs links with anchors:
These links have anchor fragments that lychee cannot check properly without the remap workaround. There was a problem hiding this comment. @copilot does lychee check links in Java files? if not, can it? There was a problem hiding this comment. By default, lychee only checks markdown and HTML files. It doesn't check Java files by default, but it can. Added There was a problem hiding this comment. By default, lychee only checks markdown and HTML files. It doesn't check Java files by default, but it can. Added |
||
| ] | ||
|
|
||
| exclude = [ | ||
| # workaround for https://github.com/lycheeverse/lychee/issues/1729 | ||
| '^https://github.com/.*#issuecomment-.*$', | ||
|
Comment on lines
+26
to
+27
There was a problem hiding this comment. @copilot check if any links in this repo need this There was a problem hiding this comment. Yes, this exclusion is needed. Found 1 GitHub issue comment link in This type of link cannot be reliably checked by lychee. There was a problem hiding this comment. @copilot does lychee check links in yml files? if not, can it? There was a problem hiding this comment. By default, lychee only checks markdown and HTML files. It doesn't check YAML files by default, but it can. Added There was a problem hiding this comment. By default, lychee only checks markdown and HTML files. It doesn't check YAML files by default, but it can. Added |
||
| "^http://localhost:", | ||
| "^http://0.0.0.0:", | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [tools] | ||
| lychee = "0.20.1" | ||
|
|
||
| [tasks.link-check] | ||
| run = 'lychee --verbose --config .github/config/lychee.toml .' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot is
*.yamlapplicable in this repo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
*.yamlis applicable. Found 2.yamlfiles in the repo:./buildscripts/templates/registry/java/weaver.yaml./buildscripts/templates/registry/incubating_java/weaver.yamlThese files don't contain HTTP links, but the pattern ensures they're checked if links are added in the future.