Conversation
RoadRunnr
force-pushed
the
feature/next-major
branch
from
0ab0e31 to
e6f81cb
Compare
Seperate concerns better. Socket managing is not in the mngr module, while the sending logic is in the client module.
There was no logic in place to remove entries from the pending registry once the timeout hits. The client side timeout would only handle re-transmission, but not the cleanup. Move the timeout logic to the sender and let it also cleanup the pending registry.
Fully prepare client suite for full IPv6 support and add some minor tweaks to the others to move them closer to IPv6 support.
RoadRunnr
force-pushed
the
feature/next-major
branch
from
e6f81cb to
a2c9a75
Compare
Was it approved for the use-cases where it was is used?
What does it give? The projects that are using old configuration need to have adjustments to handle previous eradius configuration by themselves (or to completely change/remove it what is not always possible) and to call API instead of eradius did it automatically (start servers/clients 'manually' via API). What is the purpose of it? To have some ability to do things in runtime? The old version reconfigure API, why not to add API/wrappers around set_env like add_server,remove_server and so on but break the behaviour? |
RoadRunnr
force-pushed
the
feature/next-major
branch
3 times, most recently
from
022331f to
dc3bc8e
Compare
There is no need to move existing use-case to the new code. If there is something that uses proxing, it can continue to use the old version.
Again, existing projects can stay with the version they are using. There is nothing that forces them to move. |
RoadRunnr
force-pushed
the
feature/next-major
branch
2 times, most recently
from
ec43b3c to
5a4066d
Compare
v3 rewrite of eradius, major changes: * clients and servers are now started and configured through APIs, not app env settings any more * IPv6 support * supports multiple server and client instances * metrics are optional and callback based (allows the easy use of other metrics frameworks) * distributed handlers are no longer support, use erpc to replicate in use case specific code if needed. * removed proxy support (use freeradius or similar instead)
RoadRunnr
force-pushed
the
feature/next-major
branch
from
5a4066d to
1ff6c00
Compare
…ent field - packet/1: pre-generate random authenticator for 'request' cmd before encoding attributes, so that scramble encryption (User-Password) and Message-Authenticator HMAC computation both use the same authenticator value that will be written into the packet header - encode_body/2 for 'request': use pre-generated authenticator from packet/1 if present, instead of always generating a new one - encode_message_authenticator/2: fix typo 'reqid' -> 'req_id' in pattern match, so Message-Authenticator HMAC is actually computed when msg_hmac=true - request/4: make 'client' field optional in NAS map (fall back to <<>>), since NAS maps often only carry 'secret' and omitting 'client' caused a function_clause crash on the server side when decoding incoming packets
- handle_call({reconfigure, ...}): also update #state.servers when
reconfiguring, so that new servers are actually used for sending requests
(previously only config was updated, leaving servers empty → no_active_servers)
- start_client/1: return the client manager pid instead of the supervisor pid,
so callers can pass it directly to eradius_client:send_request/3,4
(previously the supervisor pid was returned, causing send_request to crash
with {wanna_send,...} arriving at the supervisor gen_server)
3 participants
v3 rewrite of eradius, major changes:
app env settings any more
metrics frameworks)
use case specific code if needed.