Skip to content

More fixes, e.g making SSL transport possible.#5

Open
etnt wants to merge 4 commits intotravelping:masterfrom
etnt:master
Open

More fixes, e.g making SSL transport possible.#5
etnt wants to merge 4 commits intotravelping:masterfrom
etnt:master

Conversation

@etnt
Copy link

@etnt etnt commented Mar 1, 2013

Before, tcp was hardocded in flower_datapath.erl.

Torbjorn Tornkvist added 4 commits February 27, 2013 10:35
TCP was hardcoded in some places in flower_datapath.erl.
This has now been fixed and tested that SSL transport works.
@tolbrino
Copy link
Contributor

Hi Tobbe,

We think the setopts calls were misplaced in the flower_datapath module from the start and should be handled by the TransportMod in use (e.g. flower_tcp_transport). Thus, could you create a callback module for SSL and adjust the setopts calls accordingly? Also if you feel adventurous, I wouldn't mind having a test covering the tcp and ssl callback usage.

Let me know if you'll have a stab at this, otherwise we will. Your other changes look fine to me.

Cheers
Tino

@etnt
Copy link
Author

etnt commented Mar 13, 2013

Hm...we have done the transition to 80 columns already.
I've pushed the code to my fork in a branch named: 80-columns
So before any new changes are made you probably need to
decide if you want to merge in the 80-columns branch and then
we can go on from there.

The code in the branch includes all the fixes above, including the "Fixing wrong wildcard...." commit.

Cheers, Tobbe

@tolbrino
Copy link
Contributor

Yes, that is a big change. I'll have a look and update you soon on this.

@etnt
Copy link
Author

etnt commented Apr 9, 2013

Hi again, how's it going with this 80 columns thing?
It's unfortunate if we should get diverging code bases here, don't you think?

Cheers, Tobbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants