Conversation
demo-exe
requested review from
dkalashnik,
mogaika and
td2501
as code owners
Contributor
Author
|
also included changes from #66 |
Contributor
|
GRE and VXLAN are not the only tunnel interface types that uses common node. There is for example GTPU that sets common output node. We might use some of those modes in the future. |
td2501
reviewed
Sep 18, 2025
vpp-patches/0034-fix-don-t-rename-nodes-of-tunnel-interfaces.patch
Outdated
Show resolved
Hide resolved
td2501
approved these changes
Sep 18, 2025
mogaika
approved these changes
Sep 19, 2025
| + vnet_get_device_class (vnm, hw->dev_class_index); | ||
| + | ||
| + /* only rename nodes of non-tunnel ifaces */ | ||
| + if (!dev_class->has_common_nodes) |
Contributor
There was a problem hiding this comment.
Seems like this check should replace
if (dev_class->tx_function)
in vnet_delete_hw_interface. To avoid entering reuse pool at all.
Contributor
Author
There was a problem hiding this comment.
ah, I could went the other way around and used tx function here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.