Add spec

Author: AndriiMysko

lib/travis/api/app/endpoint/logs.rb

@@ -8,8 +8,11 @@ class Logs < Endpoint
       get '/:id' do |id|
         resource = service(:find_log, id: params[:id]).run
         job = resource ? Job.find(resource.job_id) : nil
+
+        halt 404 unless job
+
         repo = Travis::API::V3::Models::Repository.find(job.repository.id)
-        repo_can_write = !!repo.users.where(id: current_user.id, permissions: { push: true }).first
+        repo_can_write = current_user ? !!repo.users.where(id: current_user.id, permissions: { push: true }).first : false
 
         raise LogExpired if repo.user_settings.job_log_time_based_limit && job.started_at < Time.now - repo.user_settings.job_log_access_older_than_days.days
         raise LogAccessDenied if repo.user_settings.job_log_access_based_limit && !repo_can_write

lib/travis/api/v3/queries/log.rb

@@ -1,16 +1,14 @@
 module Travis::API::V3
   class Queries::Log < RemoteQuery
-    def find_by_job_id(repo_can_write, job_id)
-      find repo_can_write, Models::Job.find(job_id)
+    def find_by_job_id(job_id)
+      find Models::Job.find(job_id)
     end
 
-    def find(repo_can_write, job)
+    def find(job)
       @job = job
-      raise LogExpired if job.repository.user_settings.job_log_time_based_limit && job.started_at < Time.now - job.repository.user_settings.job_log_access_older_than_days.days
-      raise LogAccessDenied if job.repository.user_settings.job_log_access_based_limit && !repo_can_write
-
       remote_log = Travis::RemoteLog::Remote.new(platform: platform).find_by_job_id(platform_job_id)
       raise EntityMissing, 'log not found'.freeze if remote_log.nil?
+
       log = Travis::API::V3::Models::Log.new(remote_log: remote_log, job: job)
       # if the log has been archived, go to s3
       if log.archived?

lib/travis/api/v3/services/log/find.rb

@@ -6,8 +6,11 @@ def run!
       job = Models::Job.find(params['job.id'])
       repo_can_write = access_control.user ? !!job.repository.users.where(id: access_control.user.id, permissions: { push: true }).first : false
 
-      log = query.find(repo_can_write, job)
+      log = query.find(job)
       raise(NotFound, :log) unless access_control.visible? log
+      raise LogExpired if job.repository.user_settings.job_log_time_based_limit && job.started_at < Time.now - job.repository.user_settings.job_log_access_older_than_days.days
+      raise LogAccessDenied if job.repository.user_settings.job_log_access_based_limit && !repo_can_write
+
       result log
     end
   end