Assembla Deep Integration: Travis API Endpoint #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbarc-dt
reviewed
Jul 8, 2025
|
Let's re-review it after the changes requested are made. |
Closed
piccadilly-circus
approved these changes
Jul 25, 2025
Comment on lines
+42
to
+51
| halt 403, { error: 'Deep integration not enabled' } unless deep_integration_enabled? | ||
| halt 403, { error: 'Invalid ASM cluster' } unless valid_asm_cluster? | ||
| @jwt_payload = verify_jwt(request) | ||
| check_required_fields | ||
| end | ||
|
|
||
| def check_required_fields | ||
| missing = REQUIRED_JWT_FIELDS.select { |f| @jwt_payload[f].nil? || @jwt_payload[f].to_s.strip.empty? } | ||
| unless missing.empty? | ||
| halt 400, { error: 'Missing required fields', missing: missing } |
There was a problem hiding this comment.
Maybe create a config and add all error messages to that so it is easy to see all errors this integration can generate and then use that config where you are raising the error.
|
@piccadilly-circus @murtaza-swati Need this PR to be reviewed again as couple of changes made that came up during testing |
piccadilly-circus
approved these changes
Aug 11, 2025
Sync only passed space and repository
mshahzaib-travis
merged commit 21c3d1a
into
prd-asm_integration_dev
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a JWT-protected
/assembla/loginendpoint to Travis API for seamless Assembla user onboarding and sync.**Endpoint Parameters **
It accepts id, name, email, login, space_id, access_token, refresh_token as protected JWT parameters and returns
{ user_id: USER_ID, login: USER_LOGIN, token: USER_TOKEN, status: SIGNIN_STATUS }Setup
To use this integration, set the following environment variables in your Travis API environment:
ASSEMBLA_JWT_SECRET- Shared secret for JWT validation.ASSEMBLA_CLUSTERS- Comma-separated list of allowed Assembla clusters.DEEP_INTEGRATION_ENABLED- Set to true to enable the integration.