Initial implementation #1
Conversation
Also, enable 2FA separately via a separate endpoint
Add RepositoryPermission#owner? method
Also: * add commits and webhooks APIs * trigger webhook when a push event is triggered via webhook listener
This reverts commit 9300986.
| web_url: https://travis-vcs-proxy.travis-ci.org | ||
| api_url: https://travis-vcs-proxy-api.travis-ci.org | ||
| feedback_mail: '[email protected]' | ||
| mail_from: [email protected] |
There was a problem hiding this comment.
can it be it overriden with env?
app/models/user.rb
Outdated
| end | ||
|
|
||
| def mark_as_deleted | ||
| update_columns(email: "deleted_email_#{Kernel.rand(1_000_000_000)}", name: nil, active: false) |
There was a problem hiding this comment.
@speedywizard Just found that the email pattern is not a valid pattern so it fails when users want to delete their account.
This email pattern gives something like "deleted_email_662959238" so I thing it should be something like
"deleted_email_#{Kernel.rand(1_000_000_000)}@example.com" so it don't fail.
There was a problem hiding this comment.
@travis-architect , AFAIK, update_columns doesn't run any validations. Are you sure that it's failing because of this?
There was a problem hiding this comment.
@speedywizard I did the same in console and it was failing there too, so when I added the "@example.com" part, it got updated.
There was a problem hiding this comment.
@travis-architect ,hm, sorry, my bad - I just checked doc. It's pretty strange to me that Rails behaves in such an inconsistent way. update_column indeed skips validations, but update_columns does not
|
No description provided.