Skip to content

Fix plugin check and plugin removal wording#495

Merged
Snuffy2 merged 3 commits intotravisghansen:mainfrom
Snuffy2:Fix-plugin-check-and-plugin-removal-wording
Feb 7, 2026
Merged

Fix plugin check and plugin removal wording#495
Snuffy2 merged 3 commits intotravisghansen:mainfrom
Snuffy2:Fix-plugin-check-and-plugin-removal-wording

Conversation

@Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Feb 7, 2026

This pull request improves the accuracy and clarity of plugin cleanup status reporting in the OPNsense integration. The main changes ensure that log messages and user-facing descriptions more clearly indicate whether the OPNsense plugin is installed or not, and they refine the detection logic for the plugin's installation status.

Improvements to plugin installation detection:

  • Updated the is_plugin_installed method in pyopnsense/__init__.py to check both the package name and that the plugin is marked as installed, preventing false positives if the package entry exists but is not actually installed.

Clarifications to log messages and user-facing descriptions:

  • Updated log messages in __init__.py to explicitly state whether the OPNsense plugin is installed or not during cleanup, improving clarity for users and maintainers. [1] [2]
  • Updated the English translation in translations/en.json to clarify that the plugin is not installed when cleanup is completed, making the message more informative to end users.

Partially addresses #488

@Snuffy2 Snuffy2 added the bugfix Fix something that isn't working label Feb 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  custom_components/opnsense
  __init__.py
  custom_components/opnsense/pyopnsense
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

@Snuffy2 Snuffy2 merged commit a7d3d41 into travisghansen:main Feb 7, 2026
6 checks passed
@Snuffy2 Snuffy2 deleted the Fix-plugin-check-and-plugin-removal-wording branch February 7, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix something that isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant