Fix plugin check and plugin removal wording#495
Merged
Snuffy2 merged 3 commits intotravisghansen:mainfrom Feb 7, 2026
Merged
Conversation
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the accuracy and clarity of plugin cleanup status reporting in the OPNsense integration. The main changes ensure that log messages and user-facing descriptions more clearly indicate whether the OPNsense plugin is installed or not, and they refine the detection logic for the plugin's installation status.
Improvements to plugin installation detection:
is_plugin_installedmethod inpyopnsense/__init__.pyto check both the package name and that the plugin is marked as installed, preventing false positives if the package entry exists but is not actually installed.Clarifications to log messages and user-facing descriptions:
__init__.pyto explicitly state whether the OPNsense plugin is installed or not during cleanup, improving clarity for users and maintainers. [1] [2]translations/en.jsonto clarify that the plugin is not installed when cleanup is completed, making the message more informative to end users.Partially addresses #488