Improve and fix CI #439
Open
Improve and fix CI #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using older Rails together with concurrent-ruby version 1.3.5 or higher, Rails fails to start as shown. I addressed this by using a concurrent-ruby version below 1.3.5. ``` ruby test/timecop_with_active_support_test.rb /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/logger_thread_safe_level.rb:16:in `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError) from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/logger_thread_safe_level.rb:9:in `<module:ActiveSupport>' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/logger_thread_safe_level.rb:8:in `<top (required)>' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/logger_silence.rb:5:in `require' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/logger_silence.rb:5:in `<top (required)>' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/logger.rb:3:in `require' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/logger.rb:3:in `<top (required)>' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support.rb:29:in `require' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support.rb:29:in `<top (required)>' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/all.rb:3:in `require' from /home/runner/work/timecop/timecop/vendor/bundle/ruby/2.6.0/gems/activesupport-6.1.7.10/lib/active_support/all.rb:3:in `<top (required)>' from test/timecop_with_active_support_test.rb:4:in `require' from test/timecop_with_active_support_test.rb:4:in `<main>' ```
When running CI on Ruby 3.5, it fails as shown. As the error message indicates, rdoc was removed from the standard library, which caused the tests to fail. I fixed this by adding rdoc to the Gemfile. ``` /home/runner/work/timecop/timecop/Rakefile:4: warning: rdoc/task is found in rdoc, which is not part of the default gems since Ruby 3.5.0. You can add rdoc to your Gemfile or gemspec to fix this error. rake aborted! LoadError: cannot load such file -- rdoc/task (LoadError) /home/runner/work/timecop/timecop/Rakefile:4:in '<top (required)>' /home/runner/work/timecop/timecop/vendor/bundle/ruby/3.5.0+4/gems/rake-13.3.1/exe/rake:27:in '<top (required)>' /home/runner/.rubies/ruby-head/bin/bundle:25:in '<main>' (See full trace by running task with --trace) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI result is here.