Use POSIX shell idioms instead of explicitly requiring bash#3
Open
ngie-eign wants to merge 2 commits intotravisvn:mainfrom
Open
Use POSIX shell idioms instead of explicitly requiring bash#3ngie-eign wants to merge 2 commits intotravisvn:mainfrom
ngie-eign wants to merge 2 commits intotravisvn:mainfrom
Conversation
zsh has been shipped as the default user shell with macOS for several releases and bash has had a deprecation warning issued with it since then. The assumption made by the author is that sometime in the future the bash shell may become available. Switch from bashisms to POSIX shell equivalents so the code is guaranteed to run in both bash and zsh. NB: although this specifically focuses on suppressing Tahoe updates, this likely will work for whatever the previous set and next set of updates are, making portability more of a concern. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
ngie-eign
force-pushed
the
posix-shell
branch
from
8ef4ee5 to
b15f03c
Compare
This directory doesn't contain shell scripts; skip it to unbreak the GHA workflow. Add the `workflow_dispatch` event while here so the GHA workflow can be kicked off manually on-demand--when includes, but is not limited to, branches in forked repos. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
ngie-eign
force-pushed
the
posix-shell
branch
from
b15f03c to
7551137
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zsh has been shipped as the default user shell with macOS for several releases and bash has had a deprecation warning issued with it since then. The assumption made by the author is that sometime in the future the bash shell may become available.
Switch from bashisms to POSIX shell equivalents so the code is guaranteed to run in both bash and zsh.
NB: although this specifically focuses on suppressing Tahoe updates, this likely will work for whatever the previous set and next set of updates are, making portability more of a concern.