Conversation
|
Hi @yyuu someone from treasure-data still check pull requests from community ? |
yyuu
left a comment
yyuu
left a comment
There was a problem hiding this comment.
Sorry to be late. I have left few comments|questions. Please have a look on them 🙏
| class TdRubygems < Chef::Provider::Package::Rubygems | ||
|
|
||
| class TdGemEnvironment < AlternateGemEnvironment | ||
| def rubygems_version |
There was a problem hiding this comment.
I don't get your intention to override the inherited rubygems_version here 🤔
There was a problem hiding this comment.
Because in chef12 doesn't exists (still used by AWS Opsworks service)
| end | ||
| end | ||
|
|
||
| def needs_nodocument? |
There was a problem hiding this comment.
What is your intention to override needs_nodocument here? The only difference between 2 implementations are use of rubygems_version vs. gem_env.rubygems_version. This could mean that if TdGemEnvironment defines proper rubygems_version, we don't have to override this method here as per my understanding.
There was a problem hiding this comment.
Same reason this doesn't exists on chef 12/13
| "fluent-plugin-#{@new_resource.package_name}" | ||
| end | ||
|
|
||
| def rubygems_version |
There was a problem hiding this comment.
I think we don't have to have this method definition if we use TdGemEnvironment properly 🤔 I couldn't get your intention to define multiple rubygems_version in multiple places.
There was a problem hiding this comment.
I'm not expert, maybe for the same reason because in old chef version doesn't exists? but i'm opened to changes
2 participants
there are 2 fix inside: