feat: expand digdag skill references and consolidate workflow-management#153
Open
feat: expand digdag skill references and consolidate workflow-management#153
Conversation
c5733b2 to
3a3e50b
Compare
szyn
commented
Apr 9, 2026
|
|
||
| ```yaml | ||
| +delete_existing: | ||
| td_partial_delete>: daily_summary |
Member
Author
There was a problem hiding this comment.
td_partial_delete operator has been already deprecated. See also this release note
3a3e50b to
4dd79b3
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4dd79b3 to
aeb457d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands and reorganizes the Digdag (Treasure Workflow) documentation skill by migrating operational “workflow-management” guidance into Digdag reference docs, adding new scheduling/runtime references, and updating doc links to Treasure Data’s docs site.
Changes:
- Removed the standalone
workflow-managementskill and consolidated its content into Digdag references. - Expanded Digdag reference documentation (operators, ETL patterns, scheduling, runtime/limits) and updated official documentation links.
- Updated skill registry/docs/tests to reflect the consolidated skill set.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| workflow-skills/workflow-management/SKILL.md | Removes the standalone workflow-management skill content (migration/consolidation). |
| workflow-skills/digdag/SKILL.md | Updates Digdag skill description, operator overview, built-in variables, retry notes, and adds links to new reference docs. |
| workflow-skills/digdag/references/scheduling.md | Adds a dedicated scheduling reference (types, options, SLA, timezone notes). |
| workflow-skills/digdag/references/runtime.md | Adds runtime behavior notes (variables, secrets, concurrency, system limits). |
| workflow-skills/digdag/references/patterns-etl.md | Updates ETL patterns (idempotent refresh guidance, polling guidance). |
| workflow-skills/digdag/references/operators.md | Major expansion of operator reference content and a new secrets reference table. |
| tests/trigger-tests.yml | Removes the trigger test case for the removed workflow-management skill. |
| README.md | Removes workflow-management from the documented skill list and examples. |
| CLAUDE.md | Updates the repository tree to reflect the consolidated workflow skills structure. |
| aps-doc-skills/core/SKILL.md | Updates the Digdag documentation resource link to Treasure Workflow docs. |
| .claude-plugin/marketplace.json | Removes workflow-management from the workflow-skills plugin registration and updates description accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+11
to
+27
|
|
||
| # Daily at 9am | ||
| schedule: | ||
| daily>: "09:00:00" | ||
|
|
||
| # Weekly on Monday | ||
| schedule: | ||
| weekly>: Mon,09:00:00 | ||
|
|
||
| # Monthly on the 1st | ||
| schedule: | ||
| monthly>: 1,09:00:00 | ||
|
|
||
| # Cron (quote if starts with *) | ||
| schedule: | ||
| cron>: "*/15 * * * *" | ||
|
|
| WHERE TD_TIME_RANGE(time, '${session_time}') | ||
| ``` | ||
|
|
||
| For external systems, use `http>` with an API that returns `408` or `429` until conditions are met — `http>` retries on these status codes automatically (up to the 24h task limit). |
| @@ -260,111 +352,75 @@ Poll a table until it has enough records in the session time range. | |||
| | `interval:` | 30s | Polling frequency | | |||
| | `engine:` | — | `presto` or `hive` | | |||
ken0105
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
workflow-management was removed as a separate skill because:
sh>which is not available on TD platformCorrect content was migrated into the appropriate reference files. Incorrect examples were replaced with correct patterns.
Test plan
./tests/run-tests.sh🤖 Generated with Claude Code