-
Notifications
You must be signed in to change notification settings - Fork 37
ci/update #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clason
commented
Dec 26, 2025
- feat: update bindings
- feat: update parser with 0.26
- ci: add dependabot for GH actions
- ci: add query validation job
- feat(queries): sync with nvim-treesitter
5f7a926 to
fdcad31
Compare
|
@MunifTanjim I have synced the queries with nvim-treesitter's since they are more extensive (so give better coverage), but especially the injection queries may be too specific. Let me know if you want me to drop these to "Lua only". |
341ed24 to
45b1ce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the vim specific injections, it depends on what the goals of tree-sitter-grammars org are. If we add these vim specific ones here, would we also be adding these for other projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My stance is the following: Queries are editor- (or more generally, downstream tool-)specific, as they are the "glue" between tree-sitter and the tool functionality. As such, "grammar queries" cannot be meant to be directly used -- they are meant to be "reference queries" for
- illustrating how to use the grammar,
- adapting to downstream convention,
- catching breaking grammar changes so they can be flagged as such (and downstream users can look at the reference query changes to easily see how to adapt their own).
In this regard, the nvim-treesitter queries are not "blessed" or superior for tree-sitter-grammars projects; they're just a handy set of existing queries that are (especially for me) easy to steal. I certainly don't mean to keep them in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In particular, the specific capture names are completely irrelevant here; they are just an ignored byproduct of simply copying the queries rather than manually formatting them and then adding individual patterns.
Again, if you don't think they add value here, I'm fine just dropping them and running ts_query_ls format on the existing ones instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, let me do that first so we can separate the formatting from the additions.