Skip to content

Conversation

@ObserverOfTime
Copy link
Member

@ObserverOfTime ObserverOfTime commented Sep 9, 2025

This is an ongoing effort to update node-tree-sitter with the changes introduced in tree-sitter 0.25, and more:

@Abrifq
Copy link

Abrifq commented Oct 21, 2025

Adapt std based on Node version

Hello!
I have made a PR about this part. Should I rebase it on your PR so you can merge it when you are free to review?

#240 already exists though?
Yeah, but I made it conditional via nodejs' config.gypi. This way if it needs another version bump, it should be easier.

@ObserverOfTime
Copy link
Member Author

I already did that one.

@Abrifq
Copy link

Abrifq commented Oct 22, 2025

I already did that one.

Ah ok, didn't notice. Have a nice day then!

@ObserverOfTime ObserverOfTime marked this pull request as ready for review December 20, 2025 12:10
@ObserverOfTime
Copy link
Member Author

Basically ready. Just needs tests for the progress callbacks, which I'm too lazy to add.

The Language methods and the QueryCursor class will have to wait till the next release.

@amaanq @maxbrunsfeld

@WillLillis WillLillis merged commit f8805e7 into tree-sitter:master Jan 6, 2026
24 checks passed
@KeqingMoe
Copy link

Thank you for your tireless efforts!

@ObserverOfTime ObserverOfTime deleted the abi-15 branch January 8, 2026 08:16
@wernst
Copy link

wernst commented Jan 8, 2026

@WillLillis @ObserverOfTime just a heads up it looks like the latest publish of 0.25.1 failed

Appreciate you putting in the fix.

@WillLillis
Copy link
Member

@WillLillis @ObserverOfTime just a heads up it looks like the latest publish of 0.25.1 failed

Appreciate you putting in the fix.

We're aware, working on resolving a token permission issue that broke the last publishing run.

@Abrifq
Copy link

Abrifq commented Jan 9, 2026

@ WillLillis @ ObserverOfTime just a heads up it looks like the latest publish of 0.25.1 failed
Appreciate you putting in the fix.

We're aware, working on resolving a token permission issue that broke the last publishing run.

You can easily solve that via a short lived OIDC token generation, which happens automatically per run with Github Actions for supported platforms. (cough npm is supported cough)

See the part starting with "For the most secure deployment"
https://github.blog/changelog/2025-12-09-npm-classic-tokens-revoked-session-based-auth-and-cli-token-management-now-available/#if-you-were-still-using-npm-classic-tokens

I checked your publish workflow and looks like you only need to add the yaml file to the npm repo's trusted publisher settings.

Check https://docs.npmjs.com/trusted-publishers to learn more about it.

P.S: I have 2 suggestions for the publish workflow though:

  1. Add provenance flag to npm publish even though it says you don't need it because it needs the flag for the first generation. Silly, I know.

  2. Change from npm install to npm ci, if that will not break anything. Better defaults are almost always better, right?

       - name: Install dependencies
-        run: npm install
+        run: npm ci
 
       - name: Publish to NPM
-        run: npm publish
+        run: npm publish --provenance

@ObserverOfTime
Copy link
Member Author

Actually this seems to be a GitHub cache bug since it used an older version of the workflow.

@Abrifq
Copy link

Abrifq commented Jan 9, 2026

Actually this seems to be a GitHub cache bug since it used an older version of the workflow.

lol. lmao, even.

Anyway have a nice year everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment