-
-
Notifications
You must be signed in to change notification settings - Fork 159
Proper tree-sitter 0.25 support #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5b624a6 to
74d114f
Compare
74d114f to
386cd46
Compare
Hello!
|
|
I already did that one. |
Ah ok, didn't notice. Have a nice day then! |
386cd46 to
18d655b
Compare
- Update actions & Node.js and use arm runners - Enable trusted publishing and attestations
and deprecate the timeouts
18d655b to
4016ae0
Compare
|
Basically ready. Just needs tests for the progress callbacks, which I'm too lazy to add. The |
|
Thank you for your tireless efforts! |
|
@WillLillis @ObserverOfTime just a heads up it looks like the latest publish of 0.25.1 failed Appreciate you putting in the fix. |
We're aware, working on resolving a token permission issue that broke the last publishing run. |
You can easily solve that via a short lived OIDC token generation, which happens automatically per run with Github Actions for supported platforms. (cough npm is supported cough) See the part starting with "For the most secure deployment" I checked your publish workflow and looks like you only need to add the yaml file to the npm repo's trusted publisher settings. Check https://docs.npmjs.com/trusted-publishers to learn more about it. P.S: I have 2 suggestions for the publish workflow though:
- name: Install dependencies
- run: npm install
+ run: npm ci
- name: Publish to NPM
- run: npm publish
+ run: npm publish --provenance |
|
Actually this seems to be a GitHub cache bug since it used an older version of the workflow. |
lol. lmao, even. Anyway have a nice year everyone! |
This is an ongoing effort to update node-tree-sitter with the changes introduced in tree-sitter 0.25, and more:
-fvisibility=hiddento the flags on Linux-std=c++17. #238Introduce-> 0.26QueryCursorclasstypeproperty onSyntaxNodesubclasses withdefineProperty#257