feat: support PHP 8.6 partial function application#291
Merged
Conversation
calebdw
force-pushed
the
calebdw/push-ukvkuuvyoxpo
branch
3 times, most recently
from
b8b25fe to
fbc0f0c
Compare
Collaborator
Author
|
@cfroystad, the binding jobs are borked for the moment due to some upstream version mismatches, but the tests do pass |
cfroystad
approved these changes
Jan 5, 2026
Collaborator
cfroystad
left a comment
cfroystad
left a comment
There was a problem hiding this comment.
Note: Only reviewed the code, I trust you on the comment about tests passing locally. I've not studied the RFC closely, but from a quick read of the implementation of the RFC this looks correct
calebdw
force-pushed
the
calebdw/push-ukvkuuvyoxpo
branch
from
fbc0f0c to
dcae98e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/partial_function_application_v2