Skip to content

Conversation

vanessa-rodrigues
Copy link
Contributor

@vanessa-rodrigues vanessa-rodrigues commented Sep 26, 2025

Fixes conflict between raw reference and variable named raw.

Copy link
Contributor

@maxbrunsfeld maxbrunsfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@maxbrunsfeld
Copy link
Contributor

@ObserverOfTime Do you know what's up with the node bindings test failure? Do we need to regenerate the node bindings?

@ObserverOfTime
Copy link
Member

You need to upgrade the tree-sitter dependency.

@maxbrunsfeld
Copy link
Contributor

It looks like some examples are failing to parse now.

@vanessa-rodrigues
Copy link
Contributor Author

Yes, I am trying to reproduce it, but these tests seem to fail even before my changes.

@vanessa-rodrigues
Copy link
Contributor Author

vanessa-rodrigues commented Oct 1, 2025

Updates:

  • Removed visibility_modifier from foreign_mod_item and added optional unsafe. ref
  |
6 | pub extern "C" {
  | ^^^ help: remove the qualifier
  |
  = note: place qualifiers on individual foreign items instead

@vanessa-rodrigues
Copy link
Contributor Author

@maxbrunsfeld, the tests passed. Can we merge this?

@maxbrunsfeld maxbrunsfeld merged commit 261b202 into tree-sitter:master Oct 6, 2025
4 checks passed
@maxbrunsfeld
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants