Skip to content

fix: build errors for Node #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayant15 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: build errors for Node #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6e2a3a
fix: calls to missing tree cursor methods
mayant15 Dec 31, 2025
128f8b4
fix: pass allocator to toOwnedSlice
mayant15 Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/node.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,12 @@ pub const Node = extern struct {
return try result.toOwnedSlice(allocator);
}

try result.append(allocator, cursor.currentNode());
try result.append(allocator, cursor.node());
while (cursor.gotoNextSibling()) {
result.appendAssumeCapacity(cursor.currentNode());
result.appendAssumeCapacity(cursor.node());
}

return result.toOwnedSlice();
return result.toOwnedSlice(allocator);
}

/// Iterate over this node's named children.
Expand All @@ -241,7 +241,7 @@ pub const Node = extern struct {
}

while (true) {
var node = cursor.currentNode();
var node = cursor.node();
if (node.isNamed()) {
result.appendAssumeCapacity(node);
}
Expand Down Expand Up @@ -276,15 +276,15 @@ pub const Node = extern struct {
}

while (true) {
if (cursor.currentFieldId() == field_id) {
try result.append(allocator, cursor.currentNode());
if (cursor.fieldId() == field_id) {
try result.append(allocator, cursor.node());
}
if (!cursor.gotoNextSibling()) {
break;
}
}

return result.toOwnedSlice();
return result.toOwnedSlice(allocator);
}

/// Get this node's immediate parent.
Expand Down