Add support for assuming a role arn with sts#167
Open
icholy wants to merge 1 commit intotreeverse:mainfrom
Open
Add support for assuming a role arn with sts#167icholy wants to merge 1 commit intotreeverse:mainfrom
icholy wants to merge 1 commit intotreeverse:mainfrom
Conversation
Author
|
ruff is complaining that the |
Collaborator
|
@icholy, can this be upstreamed to s3fs? If it is possible, I'd prefer that and then wire the support here and/or in dvc. |
Author
|
@skshetry I'll see if they're open to it. |
Collaborator
|
Thanks @icholy. One more thing, s3fs and DVC uses aiobotocore instead of botocore, so if the aiobotocore provides async version of the APIs, then that'd be preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
role_arnconfig option which usessts:Assumeto create temporary credentials for the s3 operations.