Conversation
9917b36 to
044cc96
Compare
See #10700 for the motivation.
There was a problem hiding this comment.
Pull Request Overview
This PR renames the argument "url" to "repo" for the DVCFileSystem, improving the clarity of parameter names.
- Updates tests to construct DVCFileSystem using the new "repo" parameter where possible while still supporting backward compatibility.
- Adjusts the init signature and deprecation fallback in dvc/fs/dvc.py.
- Updates dependency handling in dvc/dependency/repo.py to use the new argument name.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/unit/fs/test_dvcfs.py | Updated DVCFileSystem instantiation to remove deprecated "url" usage. |
| tests/unit/fs/test_dvc.py | Updated parameterized tests to cover both "repo" and legacy "url". |
| dvc/fs/dvc.py | Modified init to prioritize the new "repo" argument and handle fallback. |
| dvc/dependency/repo.py | Adjusted dependency creation to pass "repo" instead of "url". |
Comments suppressed due to low confidence (1)
tests/unit/fs/test_dvcfs.py:781
- Consider updating the test to explicitly use the new 'repo' parameter, for example, as a positional argument or named 'repo', to align with the updated API design and improve clarity.
fs = DVCFileSystem(url=tmp_dir)
Collaborator
Author
|
Failures are unrelated and is likely due to a new pytest release. Will take a look separately. |
This was referenced Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #10700 for the motivation.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
We need to rename the
urlto something else forfsspec.core.url_to_fsto work for dvc urls withstorage_options.We have two options to consider:
repo=argument to accept bothstrandRepoinstances, orurl=to something else (preferablyrepo), and introduce a new argument for acceptingRepoinstances.Most of the API in
dvc.apialready usesrepo=(as astrpath to the DVC/Git repository, eg:dvc.api.openanddvc.api.read. So, I prefer the 1st option, as it will be a good opportunity to align naming and userepo=consistently.But I am happy with either of the options.
Also note that accepting
Repoinstance is part of an internal API, and is done for avoiding cost of opening another DVC/Git repository.Related: