Ssh error fix improvements#10769
Closed
mdawoud27 wants to merge 5 commits intotreeverse:mainfrom
mdawoud27:ssh-error-fix-improvements
Closed
Ssh error fix improvements#10769mdawoud27 wants to merge 5 commits intotreeverse:mainfrom mdawoud27:ssh-error-fix-improvements
mdawoud27 wants to merge 5 commits intotreeverse:mainfrom
mdawoud27:ssh-error-fix-improvements
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10769 +/- ##
==========================================
+ Coverage 90.68% 91.04% +0.36%
==========================================
Files 504 505 +1
Lines 39795 40091 +296
Branches 3141 3164 +23
==========================================
+ Hits 36087 36502 +415
+ Misses 3042 2957 -85
+ Partials 666 632 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve SSH Error Messages for Permission vs File Not Found Issues
Description
This PR addresses issue #7861 by improving error handling for SSH operations in the DVC codebase. Currently, when users encounter permission issues with SSH remotes, they incorrectly receive "No such file or directory" errors, which is confusing and makes troubleshooting difficult.
The implementation correctly identifies and maps Paramiko SFTP error codes to appropriate exception types, providing clear, descriptive error messages that distinguish between permission problems and missing files.
Changes
Related Issues
Fixes #7861
Checklist
❗ I have followed the Contributing to DVC checklist.
📖 Documentation update: Since this is a bug fix that improves error messages without changing the API, a separate documentation PR isn't required. However, it might be beneficial to update the troubleshooting guide to mention the improved error messages for SSH remotes.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏