HL Python SDK: fix repository create with storage_id (#9704)

* HL Python SDK: fix repository create with storage_id

* Fix test

Author: N-o-Z

clients/python-wrapper/lakefs/models.py

@@ -116,3 +116,4 @@ class RepositoryProperties(LenientNamedTuple):
     creation_date: int
     default_branch: str
     storage_namespace: str
+    storage_id: str

clients/python-wrapper/lakefs/repository.py

@@ -48,10 +48,12 @@ def create(self,
         :raise NotAuthorizedException: if user is not authorized to perform this operation
         :raise ServerException: for any other errors
         """
+        storage_id = kwargs.pop("storage_id", None)
         repository_creation = lakefs_sdk.RepositoryCreation(name=self._id,
                                                             storage_namespace=storage_namespace,
                                                             default_branch=default_branch,
-                                                            sample_data=include_samples)
+                                                            sample_data=include_samples,
+                                                            storage_id=storage_id)
 
         def handle_conflict(e: LakeFSException):
             if isinstance(e, ConflictException) and exist_ok:

clients/python-wrapper/tests/integration/test_repository.py

@@ -1,9 +1,11 @@
 import uuid
 import pytest
 
+from lakefs.exceptions import BadRequestException
 import lakefs
 
 from tests.integration.conftest import _setup_repo, get_storage_namespace
+from tests.utests.common import expect_exception_context
 
 _NUM_PREFIXES = 10
 _NUM_ELEM_PER_PREFIX = 20
@@ -49,3 +51,18 @@ def test_repositories(storage_namespace):
     assert len(repos) == 10
     for i, repo in enumerate(repos):
         assert repo.properties.id == f"{repo_base_name}{i}"
+
+
+def test_repository_create_storage_id(storage_namespace):
+    repo_id = f"test-repo{uuid.uuid4()}"
+    storage_id = ""
+    repo = lakefs.repository(repo_id).create(storage_namespace=storage_namespace, storage_id=storage_id)
+    assert repo.properties.id == repo_id
+    assert repo.properties.storage_namespace == storage_namespace
+    assert repo.properties.storage_id == storage_id
+
+def test_repository_create_storage_id_invalid_value(storage_namespace):
+    repo_id = f"test-repo{uuid.uuid4()}"
+    storage_id = "invalidvalue"
+    with expect_exception_context(BadRequestException):
+        lakefs.repository(repo_id).create(storage_namespace=storage_namespace, storage_id=storage_id)

clients/python-wrapper/tests/integration/test_sanity.py

@@ -14,7 +14,8 @@ def test_repository_sanity(storage_namespace, setup_repo):
     expected_properties = lakefs.RepositoryProperties(id=repo.properties.id,
                                                       default_branch=default_branch,
                                                       storage_namespace=storage_namespace,
-                                                      creation_date=repo.properties.creation_date)
+                                                      creation_date=repo.properties.creation_date,
+                                                      storage_id="")
     assert repo.properties == expected_properties
 
     # Create with allow exists