Make BenchmarkDrivers work again #9706
Merged
+10
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
added
bug
Copilot finished reviewing on behalf of
arielshaqed
November 20, 2025 17:58
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two critical issues that prevented the BenchmarkDrivers benchmark from working:
- Removes the
UnregisterAllDriversfunction which broke subsequent tests by clearing the global driver registry - Adds unwrapping logic for
StoreMetricsWrapperin the cleanup function to enable proper type assertion to*dynamodb.Store
Key Changes
- Replaced
UnregisterAllDrivers()with a filtering approach that removes preloaded drivers from the test comparison - Added unwrapping logic to handle
StoreMetricsWrapperbefore callingDropTable() - Added missing
dynamodbimport for driver registration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/kv/store.go | Removes the problematic UnregisterAllDrivers function |
| pkg/kv/store_test.go | Updates TestDrivers to filter preloaded drivers instead of unregistering all drivers |
| pkg/testutil/dynamodb.go | Adds unwrapping logic to handle StoreMetricsWrapper before calling DropTable() |
| pkg/kv/msg_test.go | Adds missing dynamodb import for driver registration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/testutil/dynamodb.go
Outdated
| } | ||
| err = store.(*dynamodb.Store).DropTable() | ||
| if err != nil { | ||
| tb.Fatalf("failed to delete table from DB %v %s", table, err) |
There was a problem hiding this comment.
The variable table is undefined. This should be testParams.TableName to properly reference the table name in the error message.
Suggested change
| tb.Fatalf("failed to delete table from DB %v %s", table, err) | |
| tb.Fatalf("failed to delete table from DB %v %s", testParams.TableName, err) |
- Remove UnregisterAllDrivers - it breaks all tests after it. - Unwrap StoreMetricsWrapper in GetDynamoDBProd cleanup - it breaks any use.
arielshaqed
force-pushed
the
chore/restore-kv-bench
branch
from
5ac3347 to
f13fa77
Compare
Found by Copilot, for the wrong reason.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AliRamberg
reviewed
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer please note
This is not particularly urgent; I mostly want to start collecting interesting benchmark values, and this is a good testbed. OTOH, we should not have broken code - and this benchmark was broken in two different ways.