Skip to content

feat: Introduce onInputValueChange prop to SelectBox and MultiSelectBox components #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Introduce onInputValueChange prop to SelectBox and MultiSelectBox components #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/input-elements/MultiSelectBox/MultiSelectBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export interface MultiSelectBoxProps extends React.HTMLAttributes<HTMLDivElement
defaultValue?: string[];
value?: string[];
onValueChange?: (value: string[]) => void;
onInputValueChange?: (value: string) => void;
placeholder?: string;
disabled?: boolean;
icon?: React.ElementType | React.JSXElementConstructor<any>;
Expand All @@ -44,6 +45,7 @@ const MultiSelectBox = React.forwardRef<HTMLDivElement, MultiSelectBoxProps>((pr
defaultValue,
value,
onValueChange,
onInputValueChange,
placeholder = "Select...",
disabled = false,
icon,
Expand Down Expand Up @@ -87,6 +89,11 @@ const MultiSelectBox = React.forwardRef<HTMLDivElement, MultiSelectBoxProps>((pr
onValueChange?.(newSelectedItems);
};

const handleInputValueChange = (e: React.ChangeEvent<HTMLInputElement>) => {
setSearchQuery(e.target.value);
onInputValueChange?.(e.target.value);
};

const handleReset = () => {
setSelectedValue([]);
onValueChange?.([]);
Expand Down Expand Up @@ -224,7 +231,7 @@ const MultiSelectBox = React.forwardRef<HTMLDivElement, MultiSelectBoxProps>((pr
fontSize.sm,
fontWeight.md,
)}
onChange={(e) => setSearchQuery(e.target.value)}
onChange={handleInputValueChange}
/>
</div>
<SelectedValueContext.Provider
Expand Down
5 changes: 5 additions & 0 deletions src/components/input-elements/SelectBox/SelectBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export interface SelectBoxProps extends React.HTMLAttributes<HTMLDivElement> {
defaultValue?: string;
value?: string;
onValueChange?: (value: string) => void;
onInputValueChange?: (value: string) => void;
placeholder?: string;
disabled?: boolean;
icon?: React.ElementType | React.JSXElementConstructor<any>;
Expand All @@ -48,6 +49,7 @@ const SelectBox = React.forwardRef<HTMLDivElement, SelectBoxProps>((props, ref)
defaultValue,
value,
onValueChange,
onInputValueChange,
placeholder = "Select...",
disabled = false,
icon,
Expand All @@ -56,6 +58,7 @@ const SelectBox = React.forwardRef<HTMLDivElement, SelectBoxProps>((props, ref)
onKeyDown,
...other
} = props;

const valueToNameMapping = useMemo(() => constructValueToNameMapping(children), [children]);

const [selectedValue, setSelectedValue] = useInternalState(defaultValue, value);
Expand Down Expand Up @@ -107,6 +110,8 @@ const SelectBox = React.forwardRef<HTMLDivElement, SelectBoxProps>((props, ref)
const handleInputValueChange = (e: React.ChangeEvent<HTMLInputElement>) => {
setSearchQuery(e.target.value);
setInputValue(e.target.value);

onInputValueChange?.(e.target.value);
};

const [hoveredValue, handleKeyDown] = useSelectOnKeyDown(
Expand Down