Skip to content

fix bad animation for dialog#138

Open
Louay24 wants to merge 1 commit intotremorlabs:mainfrom
Louay24:fix/dialog-animation
Open

fix bad animation for dialog#138
Louay24 wants to merge 1 commit intotremorlabs:mainfrom
Louay24:fix/dialog-animation

Conversation

@Louay24
Copy link
Copy Markdown

@Louay24 Louay24 commented May 1, 2025

Description

This PR fixes an issue with animation when opening the dialog

Related issue(s)

#136

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Screenshots (if appropriate):
Tested manually in storybook it opens fine without any bad animations
The PR fulfils these requirements:

  • It's submitted to the main branch
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@vercel
Copy link
Copy Markdown

vercel bot commented May 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ❌ Failed (Inspect) May 1, 2025 3:49pm

@maxktz
Copy link
Copy Markdown

maxktz commented May 12, 2025

Thanks!

@Louay24 Louay24 force-pushed the fix/dialog-animation branch 2 times, most recently from 3fcfde3 to 4d63b8a Compare April 4, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants