Skip to content

Commit cfe1411

Browse files
committed
grandfather NETWORK_TRANSPORT_VALUE_QUIC as stable
In the coming v1.34.0 semconv release it will be stable. open-telemetry/semantic-conventions#2275
1 parent 0a96548 commit cfe1411

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

scripts/semconv/templates/registry/ts-experimental/attributes.ts.j2

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ export const ATTR_{{ attribute.name | screaming_snake_case }} = (key: string) =>
3333
{% endif %}
3434
{% if attribute.type is mapping %}
3535
{% for espec in attribute.type.members | sort(attribute='value') %}
36-
{% if espec is not stable %}
36+
{#- Grandfather NETWORK_TRANSPORT_VALUE_QUIC as stable until v1.34.0 is released. #}
37+
{% if espec is not stable and not (attribute.name == 'network.transport' and espec.value == 'quic') %}
3738
/**
3839
* Enum value {{ espec.value | print_member_value }} for attribute {@link ATTR_{{ attribute.name | screaming_snake_case }}}.
3940
*/

scripts/semconv/templates/registry/ts-stable/attributes.ts.j2

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ export const ATTR_{{ attribute.name | screaming_snake_case }} = (key: string) =>
3131
{% endif %}
3232
{% if attribute.type is mapping %}
3333
{% for espec in attribute.type.members | sort(attribute='value') %}
34-
{% if espec is stable %}
34+
{#- Grandfather NETWORK_TRANSPORT_VALUE_QUIC as stable until v1.34.0 is released. #}
35+
{% if espec is stable or (attribute.name == 'network.transport' and espec.value == 'quic') %}
3536
/**
3637
* Enum value {{ espec.value | print_member_value }} for attribute {@link ATTR_{{ attribute.name | screaming_snake_case }}}.
3738
*/

semantic-conventions/src/experimental_attributes.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7438,11 +7438,6 @@ export const NETWORK_IO_DIRECTION_VALUE_RECEIVE = "receive" as const;
74387438
*/
74397439
export const NETWORK_IO_DIRECTION_VALUE_TRANSMIT = "transmit" as const;
74407440

7441-
/**
7442-
* Enum value "quic" for attribute {@link ATTR_NETWORK_TRANSPORT}.
7443-
*/
7444-
export const NETWORK_TRANSPORT_VALUE_QUIC = "quic" as const;
7445-
74467441
/**
74477442
* The state of event loop time.
74487443
*

semantic-conventions/src/stable_attributes.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -764,6 +764,11 @@ export const ATTR_NETWORK_TRANSPORT = 'network.transport' as const;
764764
*/
765765
export const NETWORK_TRANSPORT_VALUE_PIPE = "pipe" as const;
766766

767+
/**
768+
* Enum value "quic" for attribute {@link ATTR_NETWORK_TRANSPORT}.
769+
*/
770+
export const NETWORK_TRANSPORT_VALUE_QUIC = "quic" as const;
771+
767772
/**
768773
* Enum value "tcp" for attribute {@link ATTR_NETWORK_TRANSPORT}.
769774
*/

0 commit comments

Comments
 (0)