feat(mobile): native tabbar #15754
Closed
feat(mobile): native tabbar #15754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
Nodonisko
force-pushed
the
feat/native-tabbar
branch
from
a4c7123 to
5c5f592
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Contributor
|
Love that guy who fixed that for us 🙏. He looks familiar though 🤔... |
Nodonisko
force-pushed
the
feat/native-tabbar
branch
from
5c5f592 to
7544b33
Compare
Nodonisko
force-pushed
the
feat/native-tabbar
branch
from
7544b33 to
26b70bb
Compare
Member
|
It's really promissing, but stale. Closing the PR, keeping the branch so we can reopen later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks really cool IMHO, all that little native effects feels really "native" especially ripple effect on Android. Only drawback I found so far is that screen is not unmounted when you leave it, but I don't think that's issue anyway. There is also opened PR to
freezescreens that are not currently focus which could be good as unmount callstack/react-native-bottom-tabs#71Edit: Found blocker potentially, there is no
testIDprop rn.Edit2: Luckily some guy made PR just today callstack/react-native-bottom-tabs#179
Related Issue
Resolve #15600
Screenshots: