update: enhance TraceLog functionality

- completely unsubcribe when panel not visible
- change WindowStartupLocation to CenterOwner

Author: trgiangv

source/RevitDevTool/Commands/TraceCommand.cs

@@ -3,6 +3,7 @@
 using Nice3point.Revit.Toolkit.Decorators;
 using Nice3point.Revit.Toolkit.External;
 using RevitDevTool.View;
+using RevitDevTool.ViewModel;
 
 namespace RevitDevTool.Commands;
 
@@ -13,19 +14,19 @@ public class TraceCommand : ExternalCommand
     private const string CommandName = "TraceLog";
     private const string Guid = "43AE2B41-0BE6-425A-B27A-724B2CE17351";
     private static DockablePaneId PaneId { get; } = new(new Guid(Guid));
-    private static bool IsForceHide { get; set; } 
+    private static bool IsForceHide { get; set; }
 
     public override void Execute()
     {
         try
         {
             var dockableWindow = UiApplication.GetDockablePane(PaneId);
-            if (dockableWindow.IsShown()) 
+            if (dockableWindow.IsShown())
             {
                 dockableWindow.Hide();
                 IsForceHide = true;
             }
-            else 
+            else
             {
                 dockableWindow.Show();
                 IsForceHide = false;
@@ -43,20 +44,33 @@ public static void RegisterDockablePane(UIControlledApplication application)
             .Register(application, new Guid(Guid), CommandName)
             .SetConfiguration(data =>
             {
-                data.FrameworkElement = new TraceLog();
+                var frameworkElement = new TraceLog();
+                data.FrameworkElement = frameworkElement;
                 data.InitialState = new DockablePaneState
                 {
                     MinimumWidth = 500,
                     MinimumHeight = 400,
                     DockPosition = DockPosition.Right,
                     TabBehind = DockablePanes.BuiltInDockablePanes.PropertiesPalette
                 };
+                
+                application.DockableFrameVisibilityChanged += (_, args) =>
+                {
+                    if (args.PaneId != PaneId) return;
+
+                    if (frameworkElement.DataContext is not TraceLogViewModel vm) return;
+                    
+                    if (args.DockableFrameShown)
+                        vm.Subcribe();
+                    else
+                        vm.Dispose();
+                };
             });
 
-        application.ControlledApplication.DocumentOpened += ( _, _ ) =>
+        application.ControlledApplication.DocumentOpened += (_, _) =>
         {
             var dockableWindow = application.GetDockablePane(PaneId);
-            if (IsForceHide) 
+            if (IsForceHide)
             {
                 dockableWindow.Hide();
             }

source/RevitDevTool/ExternalEventController.cs

@@ -1,14 +1,10 @@
-using System.Collections;
 using Nice3point.Revit.Toolkit.External.Handlers;
 
 namespace RevitDevTool;
 
 public static class ExternalEventController
 {
     private static ActionEventHandler? _actionEventHandler;
-    private static AsyncEventHandler? _asyncEventHandler;
-    private static AsyncEventHandler<IEnumerable>? _asyncCollectionEventHandler;
-    private static IdlingEventHandler? _idlingEventHandler;
 
     private const string HandlerNotSetMessage = "The handler was never set.";
 
@@ -18,29 +14,8 @@ public static ActionEventHandler ActionEventHandler
         private set => _actionEventHandler = value;
     }
 
-    public static AsyncEventHandler AsyncEventHandler
-    {
-        get => _asyncEventHandler ?? throw new InvalidOperationException(HandlerNotSetMessage);
-        private set => _asyncEventHandler = value;
-    }
-
-    public static AsyncEventHandler<IEnumerable> AsyncCollectionEventHandler
-    {
-        get => _asyncCollectionEventHandler ?? throw new InvalidOperationException(HandlerNotSetMessage);
-        private set => _asyncCollectionEventHandler = value;
-    }
-    
-    public static IdlingEventHandler IdlingEventHandler
-    {
-        get => _idlingEventHandler ?? throw new InvalidOperationException(HandlerNotSetMessage);
-        private set => _idlingEventHandler = value;
-    }
-
     public static void Register()
     {
         ActionEventHandler = new ActionEventHandler();
-        AsyncEventHandler = new AsyncEventHandler();
-        AsyncCollectionEventHandler = new AsyncEventHandler<IEnumerable>();
-        IdlingEventHandler = new IdlingEventHandler();
     }
 }

source/RevitDevTool/RevitDevTool.csproj

@@ -16,7 +16,7 @@
 
     <PropertyGroup>
         <IsRepackable>true</IsRepackable>
-        <RepackBinariesExcludes>$(AssemblyName).UI*.dll;System*.dll</RepackBinariesExcludes>
+        <RepackBinariesExcludes>$(AssemblyName).UI*.dll</RepackBinariesExcludes>
     </PropertyGroup>
 
     <!-- Revit Versions -->

source/RevitDevTool/View/SettingsView.xaml

@@ -15,7 +15,7 @@
     Foreground="{DynamicResource TextFillColorPrimaryBrush}"
     WindowBackdropType="Mica"
     WindowCornerPreference="Round"
-    WindowStartupLocation="CenterScreen"
+    WindowStartupLocation="CenterOwner"
     mc:Ignorable="d">
 
     <Grid>

source/RevitDevTool/View/TraceLog.xaml.cs

@@ -10,10 +10,5 @@ public TraceLog()
         ThemeWatcher.Instance.Watch(this);
         InitializeComponent();
         DataContext = new TraceLogViewModel();
-        Loaded += (_, _) =>
-        {
-            if (DataContext is TraceLogViewModel vm)
-                vm.RefreshTheme();
-        };
     }
 }