refactor(ui): update TraceLog to use WindowsForms RichTextBox and improve theme handling

- Replaced WPF RichTextBox with WindowsForms RichTextBox for better performance.
- Enhanced theme management to dynamically adjust the log text box appearance based on the application theme.
- Streamlined initialization and disposal processes for better resource management.

Author: trgiangv

source/RevitDevTool/Commands/TraceCommand.cs

@@ -26,7 +26,7 @@ public override void Execute()
         }
         catch (Exception e)
         {
-            TaskDialog.Show("Error", e.ToString());
+            Autodesk.Revit.UI.TaskDialog.Show("Error", e.ToString());
         }
     }
 

source/RevitDevTool/RevitDevTool.csproj

@@ -2,6 +2,7 @@
 
     <PropertyGroup>
         <UseWPF>true</UseWPF>
+        <UseWindowsForms>true</UseWindowsForms>
         <Nullable>enable</Nullable>
         <LangVersion>latest</LangVersion>
         <PlatformTarget>x64</PlatformTarget>
@@ -63,7 +64,7 @@
         <PackageReference Include="ILRepack" Version="2.0.41" />
 
         <!-- Logging -->
-        <PackageReference Include="Serilog.Sinks.RichTextBox.Wpf" Version="1.1.0" />
+        <PackageReference Include="Serilog.Sinks.RichTextBox.WinForms.Colored" Version="3.1.3" />
     </ItemGroup>
 
     <ItemGroup>

source/RevitDevTool/View/TraceLog.xaml

@@ -8,6 +8,7 @@
     xmlns:sys="clr-namespace:System;assembly=mscorlib"
     xmlns:ui="http://revitdevtool.com/xaml"
     xmlns:vm="clr-namespace:RevitDevTool.ViewModel"
+    d:DataContext="{d:DesignInstance vm:TraceLogViewModel}"
     d:DesignHeight="600"
     d:DesignWidth="450"
     Background="{DynamicResource SolidBackgroundFillColorBaseBrush}"
@@ -27,11 +28,9 @@
         </ResourceDictionary>
     </Page.Resources>
 
-    <Page.DataContext>
-        <vm:TraceLogViewModel />
-    </Page.DataContext>
-
-    <DockPanel>
+    <DockPanel
+        ScrollViewer.HorizontalScrollBarVisibility="Disabled"
+        ScrollViewer.VerticalScrollBarVisibility="Disabled">
         <DockPanel
             Margin="5"
             DockPanel.Dock="Top">
@@ -60,8 +59,15 @@
             </StackPanel>
         </DockPanel>
 
-        <ContentControl
+        <Border
             Margin="5"
-            Content="{Binding LogTextBox}" />
+            Padding="2"
+            Background="{DynamicResource SolidBackgroundFillColorBaseBrush}"
+            BorderBrush="{DynamicResource ControlStrokeColorDefaultBrush}"
+            BorderThickness="1"
+            CornerRadius="6"
+            SnapsToDevicePixels="True">
+            <ContentControl Content="{Binding LogTextBox}" />
+        </Border>
     </DockPanel>
 </Page>

source/RevitDevTool/View/TraceLog.xaml.cs

@@ -1,4 +1,5 @@
 using RevitDevTool.Theme;
+using RevitDevTool.ViewModel;
 using ApplicationTheme = UIFramework.ApplicationTheme;
 #if REVIT2024_OR_GREATER
 using System.ComponentModel;
@@ -14,12 +15,18 @@ public partial class TraceLog : IDisposable
     public TraceLog()
     {
         InitializeComponent();
+        DataContext = new TraceLogViewModel(this);
 #if REVIT2024_OR_GREATER
         ApplicationTheme.CurrentTheme.PropertyChanged += ApplyTheme;
 #endif
         ThemeWatcher.Initialize();
         ThemeWatcher.Watch(this);
         ThemeWatcher.ApplyTheme();
+        Loaded += (_, _) =>
+        {
+            if (DataContext is TraceLogViewModel vm)
+                vm.RefreshTheme();
+        };
     }
 
 #if REVIT2024_OR_GREATER

source/RevitDevTool/ViewModel/TraceLogViewModel.cs

@@ -1,22 +1,30 @@
 using System.Diagnostics;
 using System.Windows;
-using System.Windows.Controls;
 using System.Windows.Media;
 using RevitDevTool.Models;
 using Serilog;
 using Serilog.Core;
 using Serilog.Events;
-using Serilog.Sinks.RichTextBox.Themes;
+using System.Windows.Forms.Integration;
+using Wpf.Ui.Appearance;
 
 namespace RevitDevTool.ViewModel;
 
 internal partial class TraceLogViewModel : ObservableObject, IDisposable
 {
-    public RichTextBox LogTextBox { get; }
+    public WindowsFormsHost LogTextBox { get; }
 
     private readonly LoggingLevelSwitch _levelSwitch;
-    private readonly SerilogTraceListener _traceListener;
     private readonly ConsoleRedirector _consoleRedirector;
+    
+    private SerilogTraceListener? _traceListener;
+    private Logger? _logger;
+    
+    private readonly RichTextBox _winFormsTextBox;
+    private readonly FrameworkElement _resourceOwner;
+    private bool _forceMonoOnLight;
+    private System.Drawing.Color _currentForeColor = System.Drawing.Color.Black;
+    
 
     [ObservableProperty] private bool _isStarted = true;
     [ObservableProperty] private LogEventLevel _logLevel = LogEventLevel.Debug;
@@ -35,7 +43,8 @@ private void TraceStatus(bool isStarted)
     {
         if (isStarted)
         {
-            Trace.Listeners.Add(_traceListener);
+            Initialized();
+            Trace.Listeners.Add(_traceListener!);
             Trace.Listeners.Add(TraceGeometry.TraceListener);
             VisualizationController.Start();
         }
@@ -44,35 +53,152 @@ private void TraceStatus(bool isStarted)
             Trace.Listeners.Remove(_traceListener);
             Trace.Listeners.Remove(TraceGeometry.TraceListener);
             VisualizationController.Stop();
+            CloseAndFlush();
         }
     }
 
-    public TraceLogViewModel()
+    private void Initialized()
+    {
+        _logger ??= new LoggerConfiguration()
+            .MinimumLevel.ControlledBy(_levelSwitch)
+            .WriteTo.RichTextBox(_winFormsTextBox)
+            .CreateLogger();
+        _traceListener ??= new SerilogTraceListener(_logger);
+    }
+
+    private void CloseAndFlush()
+    {
+        _winFormsTextBox.Clear();
+        _logger?.Dispose();
+        _traceListener?.Dispose();
+    }
+    
+
+    public TraceLogViewModel(FrameworkElement resourceOwner)
     {
-        LogTextBox = new RichTextBox
+        _resourceOwner = resourceOwner;
+        _winFormsTextBox = new RichTextBox
         {
-            FontFamily = new FontFamily("Cascadia Mono, Consolas, Courier New, monospace"),
-            VerticalScrollBarVisibility = ScrollBarVisibility.Auto,
-            VerticalContentAlignment = VerticalAlignment.Top,
-            IsReadOnly = true,
+            Font = new Font("Cascadia Mono", 9f, System.Drawing.FontStyle.Regular, GraphicsUnit.Point),
+            ReadOnly = true,
+            DetectUrls = true,
+            WordWrap = true,
+            ScrollBars = RichTextBoxScrollBars.Vertical,
+            BorderStyle = BorderStyle.None
         };
+
+        LogTextBox = new WindowsFormsHost
+        {
+            Child = _winFormsTextBox
+        };
+        
+        _winFormsTextBox.TextChanged += OnWinFormsTextChanged;
 
         PresentationTraceSources.ResourceDictionarySource.Switch.Level = SourceLevels.Critical;
         _levelSwitch = new LoggingLevelSwitch(_logLevel);
-
-        var logger = new LoggerConfiguration()
-            .MinimumLevel.ControlledBy(_levelSwitch)
-            .WriteTo.RichTextBox(LogTextBox, theme: RichTextBoxConsoleTheme.Colored)
-            .CreateLogger();
-        
-        _traceListener = new SerilogTraceListener(logger);
         _consoleRedirector = new ConsoleRedirector();
+        
+        ApplicationThemeManager.Changed += OnThemeChanged;
         TraceStatus(IsStarted);
     }
 
+    private void OnThemeChanged(ApplicationTheme theme, System.Windows.Media.Color accent)
+    {
+        LogTextBox.Dispatcher.Invoke(ApplyThemeToLogTextBox);
+    }
+
+    private void ApplyThemeToLogTextBox()
+    {
+        var bgBrush = _resourceOwner.TryFindResource("SolidBackgroundFillColorBaseBrush") as SolidColorBrush;
+        var fgBrush = _resourceOwner.TryFindResource("TextFillColorPrimaryBrush") as SolidColorBrush;
+
+        System.Drawing.Color? back = null;
+        System.Drawing.Color? fore = null;
+
+        if (bgBrush is not null)
+        {
+            var c = bgBrush.Color;
+            back = System.Drawing.Color.FromArgb(c.A, c.R, c.G, c.B);
+            _winFormsTextBox.BackColor = back.Value;
+        }
+        if (fgBrush is not null)
+        {
+            var c = fgBrush.Color;
+            fore = System.Drawing.Color.FromArgb(c.A, c.R, c.G, c.B);
+        }
+
+        // Improve readability for light themes: fallback to Black if the selected foreground is too light
+        if (back is { } b)
+        {
+            var isDark = IsDark(b);
+            if (fore is { } f)
+            {
+                if (!isDark && IsTooLight(f))
+                {
+                    f = System.Drawing.Color.Black;
+                }
+                _winFormsTextBox.ForeColor = f;
+                _currentForeColor = f;
+                // In light mode, enforce readable mono color over any fragment coloring produced by the sink
+                _forceMonoOnLight = !isDark;
+                if (_forceMonoOnLight)
+                {
+                    ForceRichTextForeColor(f);
+                }
+                else
+                {
+                    _forceMonoOnLight = false;
+                }
+            }
+
+            // Try to match scrollbars to theme (Win11/10) via Immersive Dark Mode for dark;
+            // use Explorer theme in light for modern scrollbars (handled inside helper)
+            Win32DarkMode.SetImmersiveDarkMode(_winFormsTextBox.Handle, isDark);
+        }
+    }
+    
+    private static bool IsDark(System.Drawing.Color c)
+    {
+        var lum = (0.2126 * c.R + 0.7152 * c.G + 0.0722 * c.B) / 255.0;
+        return lum < 0.5;
+    }
+
+    private static bool IsTooLight(System.Drawing.Color c)
+    {
+        var lum = (0.2126 * c.R + 0.7152 * c.G + 0.0722 * c.B) / 255.0;
+        return lum > 0.75; // very light
+    }
+    
+    private void ForceRichTextForeColor(System.Drawing.Color color)
+    {
+        try
+        {
+            _winFormsTextBox.SuspendLayout();
+            var savedStart = _winFormsTextBox.SelectionStart;
+            var savedLength = _winFormsTextBox.SelectionLength;
+            _winFormsTextBox.SelectAll();
+            _winFormsTextBox.SelectionColor = color;
+            _winFormsTextBox.SelectionStart = savedStart;
+            _winFormsTextBox.SelectionLength = savedLength;
+        }
+        finally
+        {
+            _winFormsTextBox.ResumeLayout();
+        }
+    }
+
+    private void OnWinFormsTextChanged(object? sender, EventArgs e)
+    {
+        if (_forceMonoOnLight)
+        {
+            ForceRichTextForeColor(_currentForeColor);
+        }
+    }
+
     [RelayCommand] private void Clear()
     {
-        LogTextBox.Document.Blocks.Clear();
+        CloseAndFlush();
+        Initialized();
     }
 
     [RelayCommand] private static void ClearGeometry()
@@ -82,7 +208,45 @@ [RelayCommand] private static void ClearGeometry()
 
     public void Dispose()
     {
+        ApplicationThemeManager.Changed -= OnThemeChanged;
+        _winFormsTextBox.TextChanged -= OnWinFormsTextChanged;
         _consoleRedirector.Dispose();
         GC.SuppressFinalize(this);
     }
+
+    public void RefreshTheme()
+    {
+        ApplyThemeToLogTextBox();
+    }
+}
+
+internal static class Win32DarkMode
+{
+    private const int DWMWA_USE_IMMERSIVE_DARK_MODE_BEFORE_20H1 = 19;
+    private const int DWMWA_USE_IMMERSIVE_DARK_MODE = 20;
+
+    [System.Runtime.InteropServices.DllImport("dwmapi.dll", CharSet = System.Runtime.InteropServices.CharSet.Unicode, SetLastError = true)]
+    private static extern int DwmSetWindowAttribute(IntPtr hwnd, int attr, ref int attrValue, int attrSize);
+
+    [System.Runtime.InteropServices.DllImport("uxtheme.dll", CharSet = System.Runtime.InteropServices.CharSet.Unicode, SetLastError = true)]
+    private static extern int SetWindowTheme(IntPtr hWnd, string pszSubAppName, string pszSubIdList);
+
+    public static void SetImmersiveDarkMode(IntPtr hwnd, bool enable)
+    {
+        if (hwnd == IntPtr.Zero) return;
+        var useDark = enable ? 1 : 0;
+        _ = DwmSetWindowAttribute(hwnd, DWMWA_USE_IMMERSIVE_DARK_MODE, ref useDark, sizeof(int));
+        _ = DwmSetWindowAttribute(hwnd, DWMWA_USE_IMMERSIVE_DARK_MODE_BEFORE_20H1, ref useDark, sizeof(int));
+        try
+        {
+            if (enable)
+                SetWindowTheme(hwnd, "DarkMode_Explorer", null);
+            else
+                SetWindowTheme(hwnd, "Explorer", null);
+        }
+        catch
+        {
+            // ignore if not supported
+        }
+    }
 }

source/RevitDevTool/Visualization/Helpers/RenderHelper.cs

@@ -375,7 +375,7 @@ public static void MapBoundingBoxSurfaceBuffer(RenderingBufferStorage buffer, Bo
         ];
 
         // Transform each corner individually to world coordinates
-        XYZ[] corners = localCorners
+        var corners = localCorners
             .Select(corner => box.Transform.OfPoint(corner))
             .ToArray();