Skip to content

Commit 76e4bce

Browse files
committed
refactor: test sample
- Changed type casting from Curve to Edge in CurveVisualization - Updated selection prompts for better user understanding - Simplified solid count checks in SolidVisualization
1 parent 65e168a commit 76e4bce

File tree

5 files changed

+17
-22
lines changed

5 files changed

+17
-22
lines changed

source/RevitDevTool.Test/CurveVisualization.cs

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@ public override void Execute()
1313
{
1414
try
1515
{
16-
var curveRef = UiDocument.Selection.PickObject(ObjectType.Edge,
17-
"Select Curve Element");
18-
var curve =
19-
Document.GetElement(curveRef)?.GetGeometryObjectFromReference(curveRef) as Curve;
16+
var curveRef = UiDocument.Selection.PickObject(ObjectType.Edge, "Select Curve");
17+
var curve = Document.GetElement(curveRef)?.GetGeometryObjectFromReference(curveRef) as Edge;
2018
Trace.Write(curve);
2119
}
2220
catch (Exception e)
@@ -34,13 +32,13 @@ public override void Execute()
3432
{
3533
try
3634
{
37-
var curveRefs = UiDocument.Selection.PickObjects(ObjectType.Edge,
38-
"Select Curve Elements");
39-
40-
var curves = new List<Curve>();
41-
foreach (var curveRef in curveRefs) {
42-
var curve = Document.GetElement(curveRef)?.GetGeometryObjectFromReference(curveRef) as Curve;
43-
if ( curve != null ) curves.Add( curve ) ;
35+
var curveRefs = UiDocument.Selection.PickObjects(ObjectType.Edge, "Select Curves");
36+
37+
var curves = new List<Edge>();
38+
foreach (var curveRef in curveRefs)
39+
{
40+
var curve = Document.GetElement(curveRef)?.GetGeometryObjectFromReference(curveRef) as Edge;
41+
if (curve != null) curves.Add(curve);
4442
}
4543

4644
Trace.Write(curves);

source/RevitDevTool.Test/Extensions/GeometryExtensions.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using Autodesk.Revit.DB;
2-
3-
namespace RevitDevTool.Test.Extensions;
1+
namespace RevitDevTool.Test.Extensions;
42

53
[PublicAPI]
64
public static class GeometryExtensions
@@ -108,12 +106,12 @@ public static List<Curve> GetCurves(this Solid solid)
108106
public static List<Edge> GetEdges(this Face face)
109107
{
110108
var edgeArrays = face.EdgeLoops.Cast<EdgeArray>();
111-
return edgeArrays?.SelectMany(edgeLoop => edgeLoop.Cast<Edge>()).ToList() ?? [];
109+
return edgeArrays.SelectMany(edgeLoop => edgeLoop.Cast<Edge>()).ToList();
112110
}
113111

114112
public static List<Curve> GetCurves(this Face face)
115113
{
116114
var curveLoops = face.GetEdgesAsCurveLoops();
117-
return curveLoops?.SelectMany(loop => loop.Cast<Curve>()).ToList() ?? [];
115+
return curveLoops?.SelectMany(loop => loop).ToList() ?? [];
118116
}
119117
}

source/RevitDevTool.Test/FaceVisualization.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public override void Execute()
1414
try
1515
{
1616
var faceRef = UiDocument.Selection.PickObject(ObjectType.Face, "Select Face");
17-
var face = Document.GetElement(faceRef)?.GetGeometryObjectFromReference(faceRef) as Autodesk.Revit.DB.Face;
17+
var face = Document.GetElement(faceRef)?.GetGeometryObjectFromReference(faceRef) as Face;
1818
Trace.Write(face);
1919
}
2020
catch (Exception e)
@@ -36,8 +36,7 @@ public override void Execute()
3636
var faces = new List<Face>();
3737
foreach (var faceRef in faceRefs)
3838
{
39-
var face =
40-
Document.GetElement(faceRef)?.GetGeometryObjectFromReference(faceRef) as Face;
39+
var face = Document.GetElement(faceRef)?.GetGeometryObjectFromReference(faceRef) as Face;
4140
if (face != null)
4241
{
4342
faces.Add(face);

source/RevitDevTool.Test/SolidVisualization.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public override void Execute()
1616
{
1717
var solidRef = UiDocument.Selection.PickObject(ObjectType.Element, "Select Solid Element");
1818
var solid = Document.GetElement(solidRef).GetSolids();
19-
if (solid.Any())
19+
if (solid.Count != 0)
2020
{
2121
Trace.Write(solid.First());
2222
}
@@ -43,7 +43,7 @@ public override void Execute()
4343
{
4444
var solidRefs = UiDocument.Selection.PickObjects(ObjectType.Element, "Select Solid Elements");
4545
var solids = solidRefs.SelectMany(sRef => Document.GetElement(sRef).GetSolids()).ToList();
46-
if (solids.Any())
46+
if (solids.Count != 0)
4747
{
4848
Trace.Write(solids);
4949
}

source/RevitDevTool.Test/XYZVisualization.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public override void Execute()
3333
try
3434
{
3535
var xyzRefs = UiDocument.Selection.PickObjects(ObjectType.PointOnElement);
36-
var xyzs = xyzRefs.Select(x=>x.GlobalPoint).ToList();
36+
var xyzs = xyzRefs.Select(x => x.GlobalPoint).ToList();
3737
if (xyzs.Count == 0)
3838
{
3939
Trace.TraceWarning("No points selected.");

0 commit comments

Comments
 (0)