refactor: optimize bounding box calculations by transforming corners individually

- handle OrientedBoundingBox

Author: diggtvu

source/RevitDevTool/Visualization/Helpers/RenderHelper.cs

@@ -361,21 +361,24 @@ public static void MapMeshGridBuffer(RenderingBufferStorage buffer, Mesh mesh, d
     /// using its associated transformation matrix before being processed.</param>
     public static void MapBoundingBoxSurfaceBuffer(RenderingBufferStorage buffer, BoundingBoxXYZ box)
     {
-        var minPoint = box.Transform.OfPoint(box.Min);
-        var maxPoint = box.Transform.OfPoint(box.Max);
-
-        XYZ[] corners =
+        // Generate 8 corners in LOCAL coordinate system first
+        XYZ[] localCorners =
         [
-            new(minPoint.X, minPoint.Y, minPoint.Z),
-            new(maxPoint.X, minPoint.Y, minPoint.Z),
-            new(maxPoint.X, maxPoint.Y, minPoint.Z),
-            new(minPoint.X, maxPoint.Y, minPoint.Z),
-            new(minPoint.X, minPoint.Y, maxPoint.Z),
-            new(maxPoint.X, minPoint.Y, maxPoint.Z),
-            new(maxPoint.X, maxPoint.Y, maxPoint.Z),
-            new(minPoint.X, maxPoint.Y, maxPoint.Z)
+            new(box.Min.X, box.Min.Y, box.Min.Z),  // 0: min corner
+            new(box.Max.X, box.Min.Y, box.Min.Z),  // 1
+            new(box.Max.X, box.Max.Y, box.Min.Z),  // 2
+            new(box.Min.X, box.Max.Y, box.Min.Z),  // 3
+            new(box.Min.X, box.Min.Y, box.Max.Z),  // 4
+            new(box.Max.X, box.Min.Y, box.Max.Z),  // 5
+            new(box.Max.X, box.Max.Y, box.Max.Z),  // 6: max corner
+            new(box.Min.X, box.Max.Y, box.Max.Z)   // 7
         ];
 
+        // Transform each corner individually to world coordinates
+        XYZ[] corners = localCorners
+            .Select(corner => box.Transform.OfPoint(corner))
+            .ToArray();
+
         int[] triangles =
         [
             0, 1, 2, 2, 3, 0, // bottom face
@@ -431,21 +434,24 @@ public static void MapBoundingBoxSurfaceBuffer(RenderingBufferStorage buffer, Bo
     /// vertex positions.</param>
     public static void MapBoundingBoxEdgeBuffer(RenderingBufferStorage buffer, BoundingBoxXYZ box)
     {
-        var minPoint = box.Transform.OfPoint(box.Min);
-        var maxPoint = box.Transform.OfPoint(box.Max);
-
-        XYZ[] corners =
+        // Generate 8 corners in LOCAL coordinate system first
+        XYZ[] localCorners =
         [
-            new(minPoint.X, minPoint.Y, minPoint.Z),
-            new(maxPoint.X, minPoint.Y, minPoint.Z),
-            new(maxPoint.X, maxPoint.Y, minPoint.Z),
-            new(minPoint.X, maxPoint.Y, minPoint.Z),
-            new(minPoint.X, minPoint.Y, maxPoint.Z),
-            new(maxPoint.X, minPoint.Y, maxPoint.Z),
-            new(maxPoint.X, maxPoint.Y, maxPoint.Z),
-            new(minPoint.X, maxPoint.Y, maxPoint.Z)
+            new(box.Min.X, box.Min.Y, box.Min.Z),  // 0: min corner
+            new(box.Max.X, box.Min.Y, box.Min.Z),  // 1
+            new(box.Max.X, box.Max.Y, box.Min.Z),  // 2
+            new(box.Min.X, box.Max.Y, box.Min.Z),  // 3
+            new(box.Min.X, box.Min.Y, box.Max.Z),  // 4
+            new(box.Max.X, box.Min.Y, box.Max.Z),  // 5
+            new(box.Max.X, box.Max.Y, box.Max.Z),  // 6: max corner
+            new(box.Min.X, box.Max.Y, box.Max.Z)   // 7
         ];
 
+        // Transform each corner individually to world coordinates
+        var corners = localCorners
+            .Select(corner => box.Transform.OfPoint(corner))
+            .ToArray();
+
         int[] edges =
         [
             0, 1, 1, 2, 2, 3, 3, 0, // bottom face

source/RevitDevTool/Visualization/Server/BoundingBoxVisualizationServer.cs

@@ -47,22 +47,37 @@ public sealed class BoundingBoxVisualizationServer : VisualizationServer<Boundin
     {
         if (VisualizeGeometries.Count == 0) return null;
 
-        var minPoints = VisualizeGeometries
-            .Select(box => box.Min)
-            .OrderBy(point => point.X)
-            .ThenBy(point => point.Y)
-            .ThenBy(point => point.Z);
-        var maxPoints = VisualizeGeometries
-            .Select(box => box.Max)
-            .OrderByDescending(point => point.X)
-            .ThenByDescending(point => point.Y)
-            .ThenByDescending(point => point.Z);
-        var minPoint = minPoints.FirstOrDefault();
-        var maxPoint = maxPoints.FirstOrDefault();
-        if (minPoint is null || maxPoint is null)
-            return new Outline(XYZ.Zero, XYZ.Zero);
+        var allTransformedPoints = new List<XYZ>();
 
-        return new Outline(minPoint, maxPoint);
+        foreach (var box in VisualizeGeometries)
+        {
+            // Generate all 8 corners in local coordinate system and transform them
+            XYZ[] localCorners =
+            [
+                new(box.Min.X, box.Min.Y, box.Min.Z),
+                new(box.Max.X, box.Min.Y, box.Min.Z),
+                new(box.Max.X, box.Max.Y, box.Min.Z),
+                new(box.Min.X, box.Max.Y, box.Min.Z),
+                new(box.Min.X, box.Min.Y, box.Max.Z),
+                new(box.Max.X, box.Min.Y, box.Max.Z),
+                new(box.Max.X, box.Max.Y, box.Max.Z),
+                new(box.Min.X, box.Max.Y, box.Max.Z)
+            ];
+            
+            var transformedCorners = localCorners
+                .Select(corner => box.Transform.OfPoint(corner));
+            allTransformedPoints.AddRange(transformedCorners);
+        }
+
+        // Find actual min/max from all transformed points
+        var minX = allTransformedPoints.Min(p => p.X);
+        var minY = allTransformedPoints.Min(p => p.Y);
+        var minZ = allTransformedPoints.Min(p => p.Z);
+        var maxX = allTransformedPoints.Max(p => p.X);
+        var maxY = allTransformedPoints.Max(p => p.Y);
+        var maxZ = allTransformedPoints.Max(p => p.Z);
+
+        return new Outline(new XYZ(minX, minY, minZ), new XYZ(maxX, maxY, maxZ));
     }
 
     public override void RenderScene(Autodesk.Revit.DB.View view, DisplayStyle displayStyle)