feat: support injection of env vars via secrets#30
Merged
crandles merged 2 commits intotrickstercache:mainfrom Apr 15, 2025
Merged
feat: support injection of env vars via secrets#30crandles merged 2 commits intotrickstercache:mainfrom
crandles merged 2 commits intotrickstercache:mainfrom
Conversation
Signed-off-by: Chris Randles <randles.chris@gmail.com>
jranson
reviewed
Apr 15, 2025
charts/trickster/Chart.yaml
Outdated
| # - Starting at 2.0.0 so that chart release is not confused with chart built for v1.x release | ||
| # - This version is the chart version and is different from the trickster application version | ||
| version: 2.0.0 | ||
| version: 2.1.0 |
Member
There was a problem hiding this comment.
can we keep this at 2.0.0 since the chart is not used/published as a release yet?
Signed-off-by: Chris Randles <randles.chris@gmail.com>
jranson
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for configuring environment variables based on Kubernetes secret references.
Resolves #27 (in conjunction with trickstercache/trickster#769 and trickstercache/trickster#770)
Fixes CI Lint so that it properly checks for version bumps.