Skip to content

perf: [pkg/timeseries/dataset] refactor start and end calculation#907

Merged
jranson merged 1 commit intotrickstercache:mainfrom
crandles:dataset-perf
Dec 18, 2025
Merged

perf: [pkg/timeseries/dataset] refactor start and end calculation#907
jranson merged 1 commit intotrickstercache:mainfrom
crandles:dataset-perf

Conversation

@crandles
Copy link
Contributor

@crandles crandles commented Dec 18, 2025

  1. Remove 2 extra goroutines from being created per usage of the pkg/timeseries/dataset cropper(s).

Instead of looking for the start and end time in two separate goroutines, look for the start and then end time.

This is already itself in a goroutine, the extra concurrency overhead at scale might be working against us with this particular usage.

  1. Moves away from custom binary search to using stdlib.

Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles crandles requested a review from a team as a code owner December 18, 2025 01:19
@jranson jranson merged commit 803fb57 into trickstercache:main Dec 18, 2025
7 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20322675914

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 72.114%

Totals Coverage Status
Change from base Build 20322313354: -0.03%
Covered Lines: 14911
Relevant Lines: 20677

💛 - Coveralls

@crandles crandles deleted the dataset-perf branch March 8, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants