Skip to content

feat: add support for loading multiple config files and staleness check#908

Open
Elia-Renzoni wants to merge 2 commits intotrickstercache:mainfrom
Elia-Renzoni:config-493
Open

feat: add support for loading multiple config files and staleness check#908
Elia-Renzoni wants to merge 2 commits intotrickstercache:mainfrom
Elia-Renzoni:config-493

Conversation

@Elia-Renzoni
Copy link
Contributor

@Elia-Renzoni Elia-Renzoni commented Dec 29, 2025

@jranson @crandles
This PR improves Trickster’s configuration system by extending support from a single configuration file to multiple YAML configuration files loaded from a directory.

The implementation assumes that users who want to use multiple configuration files will provide only the directory path as a flag
(e.g., /etc/trickster) and the code will automatically look for all YAML files in that directory and load them in order, merging the configurations.

To support this feature, some methods were refactored, any feedback on these changes would be appreciated.

Related Issue: #493

Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
@Elia-Renzoni Elia-Renzoni requested a review from a team as a code owner December 29, 2025 15:39
@coveralls
Copy link

coveralls commented Dec 29, 2025

Pull Request Test Coverage Report for Build 20577480854

Details

  • 65 of 87 (74.71%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 72.087%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 64 86 74.42%
Files with Coverage Reduction New Missed Lines %
pkg/proxy/engines/cache_read.go 2 81.82%
pkg/proxy/engines/progressive_collapse_forwarder.go 2 96.52%
pkg/config/config.go 4 73.72%
Totals Coverage Status
Change from base Build 20349547424: -0.04%
Covered Lines: 14958
Relevant Lines: 20750

💛 - Coveralls

Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
@jranson
Copy link
Member

jranson commented Feb 21, 2026

@Elia-Renzoni thanks so much for this, we haven't forgotten about it. We were already feature-locked and in the release candidate phase for v2.0.0 when this PR was opened. We are targeting this for v2.1.0. I'll review and test it out this week. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants