feat: add support for loading multiple config files and staleness check#908
Open
Elia-Renzoni wants to merge 2 commits intotrickstercache:mainfrom
Open
feat: add support for loading multiple config files and staleness check#908Elia-Renzoni wants to merge 2 commits intotrickstercache:mainfrom
Elia-Renzoni wants to merge 2 commits intotrickstercache:mainfrom
Conversation
Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
Pull Request Test Coverage Report for Build 20577480854Details
💛 - Coveralls |
Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
Member
|
@Elia-Renzoni thanks so much for this, we haven't forgotten about it. We were already feature-locked and in the release candidate phase for v2.0.0 when this PR was opened. We are targeting this for v2.1.0. I'll review and test it out this week. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jranson @crandles
This PR improves Trickster’s configuration system by extending support from a single configuration file to multiple YAML configuration files loaded from a directory.
The implementation assumes that users who want to use multiple configuration files will provide only the directory path as a flag
(e.g., /etc/trickster) and the code will automatically look for all YAML files in that directory and load them in order, merging the configurations.
To support this feature, some methods were refactored, any feedback on these changes would be appreciated.
Related Issue: #493